Agent stability fixes - #439
Merged
Merged
Conversation
frikky
reviewed
Jul 28, 2026
frikky
left a comment
frikky
left a comment
Member
There was a problem hiding this comment.
Looks alright. Just fix the debug thing at the top
| func HandleAiAgentExecutionStart(execution WorkflowExecution, startNode Action, createNextActions bool, callerName string, aiResponseWrapper ...[]byte) (Action, error) { | ||
|
|
||
| if debug { | ||
| if callerName == "" { |
Member
There was a problem hiding this comment.
Wouldn't this be useful outside of debug too?
Collaborator
Author
There was a problem hiding this comment.
Yes, It's useful
| callerName = "UNKNOWN_CALLER" | ||
| } | ||
|
|
||
| log.Printf("[INFO][%s] AI Agent: HandleAiAgentExecutionStart invoked by caller: '%s' (createNextActions=%t, node=%s, status=%s)", execution.ExecutionId, callerName, createNextActions, startNode.ID, execution.Status) |
Member
There was a problem hiding this comment.
For consistency: If you do debug printing, add actual [DEBUG]
That way it's easy to differentiate if debug is enabled
Collaborator
Author
|
@frikky This is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contain fixes to state-consistency bugs due to cache and premature recovery firing from Fixexecution and agent continuation