Merged
Conversation
…e peice at a time. Removed everything and started adding things back to a basic working vue app. Currently just some classes and some store files have been added and imported to check them for proper running. The temp page runs while importing some of the js classes right now.
…nding page working. Had to modify some code a little. Also, added some of the configuration files back since their options are necessary for some of our code to work.
… being found. I was unable to get the card images to properly show up with the previous methods. This bypasses any webpack which I am not exactly sure how it will affect the program. It is probably not the 'best' method, but will do for now.
… some issues with build size. Not all fixes are the best, but have been made for now to get things working.
…nt-disable directives.
…. I had to add sinon as it was being used in the unit tests, but it may not be necessary as I beleive that jest has similar functionality built in. A couple of AI tests that sort the cards are no longer passing and I have no idea what this is about. I don't think anything I have done has changed their behaviour, but it will need to be looked into.
…already been there.
…have to install it gloabally to be able to work with the project.
…ing tests I beleive are a problem with the tests. These need to be changed and have been commented with some thoughts. The errors issued with teh card tests are a problem with testing with vuex. These tests will also need to be re-written to properly mock out objects or stub out getters. This has been commented with a link to the vue docs on testing with vuex. Now all tests are passing again.
…ed out tests. Gave some information why they are commented out and they will be fixed when the broken tests are fixed. I am leaving all this code for the moment to ensure that we can see what was intended from these tests when re-writting them. Also, removed some comments above tests that were essentially identical to the string given as the test name.
Main purpose is to test the current changes with some CI. Perhaps can be used to replace the Travis CI with the original setup if it makes things simpler and has the necessary features.
change style:lint name to the proper one
…ed the program-wars paper to the supportDocs folder.
…ne has changed for now.
Merge dependency updates into a local branch to test before considering merging into master
Set to run on all push to any branch. For now just to see if it will run for this branch and confirm that things are working. May revert back to only master before merging with master.
johnanvik
approved these changes
May 19, 2020
Collaborator
johnanvik
left a comment
johnanvik
left a comment
There was a problem hiding this comment.
Looks good. Seems like the program may be running faster and some of the graphics look sharper.
This was referenced May 27, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525, #514, #515
Overview of changes
$ npm run devbut instead$ npm run serveto setup the development server. There are alsorun lintandrun lint:styleto check for code issues andrun docsto build the docs. Therun testscript is still available and runs coverage as well. The coverage is not integrated with coveralls yet, but the developer can see the results when they run the tests.Reviewer: @johnanvik