1.5.5 Toolchange is broken

[gcormier]

Just had to revert to 1.5.4. Not sure what's up.

1. Ran a job, multiple tools. I aborted during a toolchange for the last tool of the job, wasn't happy with something.
2. Changed CAM, posted, loaded in gSender. As soon as I hit start, it would NOT measure the intiial tool.
3. I reposted 5-6 times. I edited the file to throw in a random tool #.
4. Reloaded gSender, rebooted SLBEXT, no change
5. Installed 1.5.4, loaded the same file that was not working, run job, boom - measure initial tool.

Not sure what's up. I did notice during the toolchange wizard it did mention T255 as the tool - I don't use that tool.

[gcormier]

A few extra notes

My gcode had a standard start

G90 G94
G17
G21

M9
G28 G91 Z0
G90

M6 T6
S22000 M3
G54
M7
M7
G0 X3.55 Y-251.5

Hitting run in gSender, the spindle would immediately turn on and start the program. It's as if M6 T6 wasn't there.

I was wondering if somehow it thought that tool was already loaded, so I manually changed the line to say M6 T55, load it, run it - same behavior.

I did many post-processes in between, but the final step was

1. Run a file in 1.5.5, bad behavior
2. Install 1.5.4
3. Run the exact same file as in step 1 - proper behavior.

No changes to the file was done between .5.5 and .5.4.

[kglovern]

This was a change made while I was on vacation that was not properly discussed with the team and has been reverted which will be in the next release/current actions. The TLDR is that early M6s were made to be removed to prevent prompting a tool change at the start of the file which was confusing some users as they already have their initial tool loaded. Instead this will be moved into dev, and the behaviour will be to not prompt for an early tool change if _current_tool matches the T command requested and otherwise pop up the wizard as expected.

[gcormier]

The thinking makes sense in the context of upcoming ATC stuff. Probably needs to be an option or check if an ATC is being used.

Have downloaded the action build, next time I run a multi tool job I can confirm but looking at the commit, it will surely be resolved :)