Replace Umami analytics with the new Analytics battery#615
Merged
Conversation
…gration Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NutKW958x2VF9rVagycenv
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 73.18% 73.25% +0.06%
==========================================
Files 30 30
Lines 2111 2109 -2
==========================================
Hits 1545 1545
+ Misses 566 564 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Umami analytics is being retired in favor of the new self-hosted analytics server at https://analytics.sierrasoftworks.com. This PR migrates
github-backupto thetracing-batteriesAnalyticsbattery, which replaces the oldUmamibattery.tracing-batteriescargo feature flag fromumamitoanalyticsinCargo.toml.Umami::new(server_url, website_id).with_initial_page("/.app/")withAnalytics::new(server_url). The new battery takes only the server URL (no website ID) and no longer needs the/.app/page-prefix convention — it defaults to page/on a virtual hostname of{service}.app.use tracing_batteries::{...}import accordingly.Cargo.lockviacargo update tracing-batteriesto pull in the latestmainof thetracing-batteries-rsgit dependency, which ships theAnalyticsbattery.No changes were needed to the existing
session.record_new_page(format!("/backup/{}", policy))call — it already uses a clean path.Test plan
cargo checkpassescargo clippy --all-targetspasses with no warningscargo test— 111 passed; 6 pre-existing failures unrelated to this change (network/TLS errors reachingapi.github.comfrom the sandbox, in GitHub API test helpers, not the analytics code)🤖 Generated with Claude Code
https://claude.ai/code/session_01NutKW958x2VF9rVagycenv
Generated by Claude Code