feat: build the tabs component (primary and secondary)#36
Merged
ahmadshaheer merged 11 commits intomainfrom Apr 25, 2025
Merged
feat: build the tabs component (primary and secondary)#36ahmadshaheer merged 11 commits intomainfrom
ahmadshaheer merged 11 commits intomainfrom
Conversation
|
This looks good. You can merge this @ahmadshaheer |
GeekBoySupreme
approved these changes
Mar 26, 2025
GeekBoySupreme
suggested changes
Mar 26, 2025
GeekBoySupreme
left a comment
GeekBoySupreme
left a comment
There was a problem hiding this comment.
The highlight rectangle has a border-radius greater than 4px, can we please fix that before merging?
ahmadshaheer
force-pushed
the
feat/tabs-component
branch
from
018aad4 to
42253f3
Compare
ahmadshaheer
force-pushed
the
feat/tabs-component
branch
from
3866fbe to
b3ceb09
Compare
ahmadshaheer
force-pushed
the
feat/tabs-component
branch
from
b3ceb09 to
689d153
Compare
ahmadshaheer
changed the title
YounixM
approved these changes
Apr 24, 2025
aks07
approved these changes
Apr 25, 2025
This was
linked to
issues
Apr 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/design/egMidgk6VJDXTumxcCYUl1/Periscope---Primitives?node-id=12-744&t=RbZH2WgEFV9o7vWd-1