feat: button component + all variants + light / dark mode + storybook story#48
Merged
feat: button component + all variants + light / dark mode + storybook story#48
Conversation
aks07
previously approved these changes
Apr 24, 2025
Contributor
aks07
left a comment
aks07
left a comment
There was a problem hiding this comment.
one minor comment; can be taken up in subsequent PRs
ahmadshaheer
changed the base branch from
feat/setup-mode-and-theme-support-using-tailwind-v4
to
main
ahmadshaheer
force-pushed
the
feat/button-component
branch
from
aafdd53 to
c54523d
Compare
Member
|
@ahmadshaheer : As per the attached screenshots, the light mode and dark mode are inverted |
Contributor
Author
@YounixM, the light/dark labels shown in the screenshot are to switch between light and dark mode. will improve the UI and make it similar to #36 |
aks07
previously approved these changes
Apr 25, 2025
ahmadshaheer
force-pushed
the
feat/button-component
branch
from
c54523d to
9a27554
Compare
aks07
approved these changes
Apr 25, 2025
YounixM
approved these changes
Apr 25, 2025
Closed
Closed
Closed
This was referenced Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close https://github.com/SigNoz/engineering-pod/issues/2301