Merged
Conversation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ab97247 in 1 minute and 44 seconds
More details
- Looked at
156lines of code in3files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. ee/query-service/main.go:25
- Draft comment:
Ensure all OTLP zap encoder logic/config has been completely removed, and that the logging configuration remains correct. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure that a specific part of the code has been completely removed and that the logging configuration remains correct. This falls under the rule of not asking the PR author to ensure or verify things, which is not allowed.
2. go.mod:11
- Draft comment:
Removed OTLP zap encoder dependencies; verify that no code still references these packages. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to verify that no code still references the removed dependencies. This falls under the rule of not asking the author to double-check things, which is not allowed.
3. go.sum:1
- Draft comment:
The go.sum changes show removal of OTLP zap encoder hashes; ensure all related entries are cleaned up. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. go.mod:8
- Draft comment:
Removed dependencies on the OTLP zap encoder modules (e.g. github.com/SigNoz/zap_otlp/zap_otlp_encoder and zap_otlp_sync). Verify that logger configuration now uses the standard encoder and that no residual references remain. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. go.sum:1
- Draft comment:
Ensure that the removal of OTLP zap encoder dependencies in go.sum is complete and that no outdated checksums remain. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. ee/query-service/main.go:59
- Draft comment:
The flag 'use-logs-new-schema' at line 59 has a description that refers to 'logs_v2 schema for logs'. Please clarify whether this flag is for enabling a new schema or the legacy v2 schema, and update the description accordingly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. ee/query-service/main.go:56
- Draft comment:
Consider renaming the variable 'gatewayUrl' (declared at line 56) to 'gatewayURL' to follow standard acronym capitalization conventions. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_mU3MbvKzQFu6yGfQ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nityanandagohain
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove otlp zap encoder.
Related Issues / PR's
Already archived https://github.com/SigNoz/zap_otlp
Part of #6805
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Remove OTLP zap encoder and related dependencies from the codebase.
initZapLog()inmain.go. No longer supports OTLP log export.enableQueryServiceLogOTLPExportflag frommain()inmain.go.github.com/SigNoz/zap_otlp/zap_otlp_encoderandgithub.com/SigNoz/zap_otlp/zap_otlp_syncfromgo.mod.google.golang.org/grpcfromgo.modand added it as an indirect dependency.initZapLog()to useCapitalColorLevelEncoderfor log level encoding.This description was created by
for ab97247. It will automatically update as commits are pushed.