fix: prevented infraMonitoring styles from overriding at other places#7425
Merged
SagarRajput-7 merged 1 commit intomainfrom Mar 24, 2025
Merged
fix: prevented infraMonitoring styles from overriding at other places#7425SagarRajput-7 merged 1 commit intomainfrom
SagarRajput-7 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 36aa003 in 1 minute and 19 seconds
More details
- Looked at
71lines of code in1files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:711
- Draft comment:
Usage of :has() pseudo-class is modern but verify browser support meets target requirements. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to verify browser support for the:has()pseudo-class, which is not allowed as per the rules. It doesn't provide a specific suggestion or point out a clear issue with the code.
2. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:705
- Draft comment:
Good encapsulation: Wrapping the table cell overrides in.infra-monitoring-containerlimits the scope and prevents leaking styles globally. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:707
- Draft comment:
Consider reducing the use of !important if possible to improve maintainability, unless absolutely necessary to override external library styles. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
4. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:712
- Draft comment:
Ensure the browser support for the CSS :has pseudo-class meets our target requirements, as its support can be limited. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure browser support for a CSS feature, which falls under the category of asking the author to double-check or verify something. This violates the rule against asking the author to confirm or ensure things.
5. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:706
- Draft comment:
There are multiple separate.ant-table-cellblocks; consider consolidating them to reduce duplication and improve clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
6. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:736
- Draft comment:
Double-check that both the nested rule within.expanded-k8s-list-tableand the standalone.ant-table-row-expand-icon-cellrule are required to cover all cases without unintended side effects. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
7. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss:768
- Draft comment:
Typographical error: 'background-color: none !important;' is not a valid CSS value. Consider replacing it with 'background-color: transparent !important;' to ensure correct styling. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_dUqIWsoadOaLMNmA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.styles.scss
Show resolved
Hide resolved
amlannandy
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
antdcell override at the global place which effected and messed-up at other places -PlannedDowntimeRelated Issues / PR's
Screenshots
Before:
Screen.Recording.2025-03-24.at.8.50.11.PM.mov
After:
Screen.Recording.2025-03-24.at.8.49.13.PM.mov
Affected Areas and Manually Tested Areas
Important
Scopes table cell styles to
.infra-monitoring-containerinInfraMonitoringK8s.styles.scssto prevent global overrides..ant-table-cellstyles within.infra-monitoring-containerto prevent global overrides inInfraMonitoringK8s.styles.scss..ant-table-row-expand-icon-cellstyles under.expanded-k8s-list-tablewithin.infra-monitoring-container.This description was created by
for 36aa003. It will automatically update as commits are pushed.