fix: telemetry version function call#7453
Merged
therealpandey merged 1 commit intomainfrom Mar 27, 2025
Merged
Conversation
therealpandey
approved these changes
Mar 27, 2025
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 74f0093 in 1 minute and 13 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. pkg/query-service/telemetry/telemetry.go:743
- Draft comment:
Ensure that version.Info is now a function. Confirm all uses are updated to call version.Info.Version() to avoid runtime errors. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. pkg/query-service/telemetry/telemetry.go:743
- Draft comment:
Good fix – calling version.Info.Version() (a function) ensures the proper version string is retrieved rather than referencing a static field. Ensure that this function call has no unintended side effects. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is informative and asks the author to ensure there are no unintended side effects, which violates the rules. It doesn't provide a specific suggestion or point out a clear issue.
3. pkg/query-service/telemetry/telemetry.go:114
- Draft comment:
Consider renaming the variable 'random_number' to 'randomNumber' for consistency with Go's camelCase naming convention. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. pkg/query-service/telemetry/telemetry.go:683
- Draft comment:
Consider renaming 'email_split' to 'emailSplit' to adhere to Go's camelCase naming style. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_soxWSJwBRp5AjstN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix telemetry version function call
Important
Fixes version retrieval in
SendEvent()intelemetry.goby usingversion.Info.Version()instead ofversion.Info.Version.SendEvent()intelemetry.goby changingversion.Info.Versiontoversion.Info.Version().This description was created by
for 74f0093. It will automatically update as commits are pushed.