Skip to content

Comments

fix: telemetry version function call#7453

Merged
therealpandey merged 1 commit intomainfrom
fix/telemetry-version-track-events
Mar 27, 2025
Merged

fix: telemetry version function call#7453
therealpandey merged 1 commit intomainfrom
fix/telemetry-version-track-events

Conversation

@makeavish
Copy link
Member

@makeavish makeavish commented Mar 27, 2025

Summary

Fix telemetry version function call


Important

Fixes version retrieval in SendEvent() in telemetry.go by using version.Info.Version() instead of version.Info.Version.

  • Behavior:
    • Fixes version retrieval in SendEvent() in telemetry.go by changing version.Info.Version to version.Info.Version().
  • Misc:
    • No other changes or additions.

This description was created by Ellipsis for 74f0093. It will automatically update as commits are pushed.

@makeavish makeavish requested a review from therealpandey March 27, 2025 14:06
@github-actions github-actions bot added the bug Something isn't working label Mar 27, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 74f0093 in 1 minute and 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. pkg/query-service/telemetry/telemetry.go:743
  • Draft comment:
    Ensure that version.Info is now a function. Confirm all uses are updated to call version.Info.Version() to avoid runtime errors.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. pkg/query-service/telemetry/telemetry.go:743
  • Draft comment:
    Good fix – calling version.Info.Version() (a function) ensures the proper version string is retrieved rather than referencing a static field. Ensure that this function call has no unintended side effects.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is informative and asks the author to ensure there are no unintended side effects, which violates the rules. It doesn't provide a specific suggestion or point out a clear issue.
3. pkg/query-service/telemetry/telemetry.go:114
  • Draft comment:
    Consider renaming the variable 'random_number' to 'randomNumber' for consistency with Go's camelCase naming convention.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. pkg/query-service/telemetry/telemetry.go:683
  • Draft comment:
    Consider renaming 'email_split' to 'emailSplit' to adhere to Go's camelCase naming style.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_soxWSJwBRp5AjstN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@therealpandey therealpandey merged commit c36f913 into main Mar 27, 2025
12 of 14 checks passed
@therealpandey therealpandey deleted the fix/telemetry-version-track-events branch March 27, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants