chore: add third party feature flag#7458
Closed
shivanshuraj1333 wants to merge 1 commit intoSigNoz:mainfrom
Closed
chore: add third party feature flag#7458shivanshuraj1333 wants to merge 1 commit intoSigNoz:mainfrom
shivanshuraj1333 wants to merge 1 commit intoSigNoz:mainfrom
Conversation
Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
|
We would appreciate it if you could provide us with more info about this issue/pr! |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7350760 in 1 minute and 44 seconds
More details
- Looked at
68lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. ee/query-service/model/plans.go:157
- Draft comment:
Added ThirdPartyApi feature flag in Basic, Pro, and Enterprise plans. Ensure that corresponding business logic and tests are updated accordingly. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. pkg/query-service/model/featureSet.go:27
- Draft comment:
Introduced the ThirdPartyApi constant. Consider adding documentation to clarify its intended use and ensure consistency across modules. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
3. ee/query-service/model/plans.go:157
- Draft comment:
Add inline documentation for 'ThirdPartyApi' to clarify its purpose in each plan. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
4. pkg/query-service/model/featureSet.go:27
- Draft comment:
Consider adding a comment for the 'ThirdPartyApi' constant to document its intended use. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
Workflow ID: wflow_BUWmG8FlNs1zzz1S
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
ThirdPartyApifeature flag to various plans, initially inactive, inplans.goandfeatureSet.go.ThirdPartyApifeature toBasicPlan,ProPlan, andEnterprisePlaninplans.go.ThirdPartyApifeature toBasicPlaninfeatureSet.go.ThirdPartyApiconstant infeatureSet.go.ThirdPartyApiis initially inactive (Active: false) across all plans.This description was created by
for 7350760. It will automatically update as commits are pushed.