Skip to content

Comments

chore: add third party feature flag#7458

Closed
shivanshuraj1333 wants to merge 1 commit intoSigNoz:mainfrom
shivanshuraj1333:third-party-feat-flag
Closed

chore: add third party feature flag#7458
shivanshuraj1333 wants to merge 1 commit intoSigNoz:mainfrom
shivanshuraj1333:third-party-feat-flag

Conversation

@shivanshuraj1333
Copy link
Contributor

@shivanshuraj1333 shivanshuraj1333 commented Mar 27, 2025

Important

Add ThirdPartyApi feature flag to various plans, initially inactive, in plans.go and featureSet.go.

  • Feature Addition:
    • Add ThirdPartyApi feature to BasicPlan, ProPlan, and EnterprisePlan in plans.go.
    • Add ThirdPartyApi feature to BasicPlan in featureSet.go.
  • Constants:
    • Define ThirdPartyApi constant in featureSet.go.
  • Behavior:
    • ThirdPartyApi is initially inactive (Active: false) across all plans.

This description was created by Ellipsis for 7350760. It will automatically update as commits are pushed.

Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
@request-info
Copy link

request-info bot commented Mar 27, 2025

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7350760 in 1 minute and 44 seconds

More details
  • Looked at 68 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. ee/query-service/model/plans.go:157
  • Draft comment:
    Added ThirdPartyApi feature flag in Basic, Pro, and Enterprise plans. Ensure that corresponding business logic and tests are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. pkg/query-service/model/featureSet.go:27
  • Draft comment:
    Introduced the ThirdPartyApi constant. Consider adding documentation to clarify its intended use and ensure consistency across modules.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. ee/query-service/model/plans.go:157
  • Draft comment:
    Add inline documentation for 'ThirdPartyApi' to clarify its purpose in each plan.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
4. pkg/query-service/model/featureSet.go:27
  • Draft comment:
    Consider adding a comment for the 'ThirdPartyApi' constant to document its intended use.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None

Workflow ID: wflow_BUWmG8FlNs1zzz1S


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant