-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: typos #7881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: typos #7881
Conversation
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 6d21364 in 1 minute and 52 seconds. Click for details.
- Reviewed
395lines of code in24files - Skipped
0files when reviewing. - Skipped posting
25draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pkg/query-service/app/logs/v4/query_builder.go:103
- Draft comment:
Potential formatting issue in getExistsNexistsFilter: when key.IsColumn is true, the format string uses an extra backtick. Consider changing%s_exists=%vto%s_exists=%v` to avoid stray backticks. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. pkg/query-service/app/logs/v4/query_builder.go:352
- Draft comment:
Avoid using magic numbers directly. The value 1800 (used to adjust bucket start in buildLogsQuery) should be defined as a named constant to improve code readability and maintainability. - Reason this comment was not posted:
Comment was on unchanged code.
3. pkg/query-service/app/logs/v4/query_builder.go:352
- Draft comment:
Consider extracting the magic number 1800 (used in the bucketStart calculation) into a well‐named constant. This will improve readability and ease future maintenance. - Reason this comment was not posted:
Comment was on unchanged code.
4. pkg/query-service/app/logs/v4/query_builder.go:304
- Draft comment:
In generateAggregateClause, the calculation for rate (casting step to float and then adjusting based on total duration for table panels) is non‐trivial. Consider adding comments or extracting this logic into a helper function to clarify the rationale. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. pkg/query-service/app/logs/v4/query_builder.go:140
- Draft comment:
Ensure that the value passed into the query is properly sanitized. Verify that utils.ClickHouseFormattedValue (used on line 142) safely escapes user‑supplied input to prevent any risk of SQL injection. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. pkg/query-service/app/logs/v4/query_builder.go:104
- Draft comment:
Review the formatting in getExistsNexistsFilter for materialized columns. The construction of the string using trimmed getClickhouseKey and appending '_exists`' should be verified for correct SQL syntax. Consider adding tests or refactoring this into a helper to ensure consistent escaping. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. docs/otel-demo-docs.md:231
- Draft comment:
Typo: Change "it's UI" to "its UI" to correctly indicate possession in the phrase "Signoz exposes its UI". - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. frontend/src/AppRoutes/routes.ts:26
- Draft comment:
There's a potential typographical error in the import name 'ListAllALertsPage'. It seems like it might be intended to be 'ListAllAlertsPage' (with a lowercase 'l' after 'A'). Please verify and correct if necessary. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. frontend/src/container/BillingContainer/BillingContainer.test.tsx:75
- Draft comment:
Typo: Consider renaming 'freeTrailText' to 'freeTrialText' to match the correct spelling of 'trial'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. frontend/src/container/BillingContainer/BillingContainer.test.tsx:83
- Draft comment:
Typo: The variable 'onTrail' likely should be renamed to 'onTrial' for consistency with 'Free Trial'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
11. frontend/src/container/BillingContainer/BillingContainer.test.tsx:136
- Draft comment:
Typo: The test name 'Not on ontrail' likely contains a typo. Consider renaming it to 'Not on trial' for clarity and consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
12. frontend/src/container/LogDetailedView/utils.tsx:266
- Draft comment:
Typographical issue: In the regex for matching ANSI escape sequences in the removeEscapeCharacters function (lines 266-267), the regex pattern uses[[0-9;]*which seems incorrect. It likely should escape the[(e.g.,\[[0-9;]*m) to properly match the literal '[' character. Please review and fix the regex patterns to accurately capture the intended escape sequences. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. frontend/src/container/MySettings/__tests__/MySettings.test.tsx:163
- Draft comment:
Typo in the error message text. Consider correcting it to something like 'Password must have a minimum of 8 characters'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
14. frontend/src/container/MySettings/__tests__/MySettings.test.tsx:168
- Draft comment:
Typographical error in test description: 'inavlid credentials' should be corrected to 'invalid credentials'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
15. frontend/src/container/OnboardingContainer/Modules/LogsManagement/SysLogs/syslogs.md:44
- Draft comment:
Typographical error: The sentence 'and adding the this line at the end' contains an extra article. Consider revising it to 'and adding this line at the end' or 'and add this line at the end' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
16. frontend/src/container/PipelinePage/PipelineListsView/Preview/components/SampleLogs/SampleLogsResponseDisplay.tsx:12
- Draft comment:
Typo corrected: changed 'An error occured while querying sample logs' to 'An error occurred while querying sample logs'. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only points out a typo correction. It doesn't provide any actionable feedback or suggestions for improvement.
17. frontend/src/container/QueryBuilder/filters/HavingFilter/__tests__/utils.test.tsx:65
- Draft comment:
Typographical error: In the test description on line 65, consider changing "Is having filter is enable" to "Is having filter enabled" for better readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
18. frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx:116
- Draft comment:
Typo: The state variable 'dynamicPlacholder' is misspelled. It should be 'dynamicPlaceholder' for clarity and consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
19. frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx:434
- Draft comment:
Typo: In the comment 'when clicking on the button the search bar looses the focus', 'looses' should be 'loses'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
20. frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx:843
- Draft comment:
There's a small typo in the comment on line 843: 'sycn' should be spelled 'sync'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
21. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:95
- Draft comment:
Typo: Consider renaming 'isValidteRelativeTime' to 'isValidRelativeTime' (or a consistent variation) for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
22. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:341
- Draft comment:
Typo: 'minutedDiff' is likely intended to be 'minutesDiff'. Please consider renaming for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
23. frontend/src/hooks/useResourceAttribute/__tests__/useResourceAttribute.test.tsx:17
- Draft comment:
Typo corrected: changed '/inital-url?tab=overview' to '/initial-url?tab=overview'. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that a typo was corrected. It does not provide any actionable feedback or suggestions for improvement.
24. pkg/query-service/app/logs/v4/query_builder.go:130
- Draft comment:
Typo found in TODO comment: instead of "as of now __attrs is only supports attributes_string", consider rephrasing to "as of now __attrs only supports attributes_string". - Reason this comment was not posted:
Comment was on unchanged code.
25. pkg/query-service/app/logs/v4/query_builder.go:228
- Draft comment:
Typographical error: 'materialzied' should be corrected to 'materialized'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_IfgdSKlsJJMz4mXp
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
fix: typos
Important
Fixes various typos in comments, strings, and variable names across multiple files to improve code readability and correctness.
docs/otel-demo-docs.md.billings.json,BillingContainer.tsx, andIntegrationDetailHeader.tsx.ClientSideQBSearch.tsxandQueryBuilderSearchV2.tsx.SampleLogsResponseDisplay.tsxandhttp_handler.go.PlannedDowntime.tsxandPlannedDowntimeutils.ts.applicationLogsFromLogFile.mdandsyslogs.md.utils.test.tsx.useResourceAttribute.test.tsx.DateTimeSelectionV2/index.tsx.ROUTES_NOT_TO_BE_OVERRIDENtoROUTES_NOT_TO_BE_OVERRIDDENinPrivate.tsxandroutes.ts.GET_INTIAL_APPLICATION_DATAtoGET_INITIAL_APPLICATION_DATAinmetric.tsandmetrics.ts.This description was created by
for 6d21364. You can customize this summary. It will automatically update as commits are pushed.