fix: run reconcileSubscription after every fetch attempt

[jimmy-phantom]

Summary

Reactive getConfig() that switches subscribe to undefined on an error response (e.g. poll only while response.ok) silently failed when the error body did not match the result entity shape.

runQuery only called reconcileSubscription after applyData succeeded (QueryResult.ts:337), so parseEntities throwing on the body shape skipped the reconcile, the inner reactiveSignal never re-read this.config, and the running poll subscriber kept ticking against stale config.

Fix

Move the reconcileSubscription call into a finally block so it fires after every fetch attempt, regardless of whether parsing succeeds.

     return withRetry(
       async () => {
-        const freshData = await adapter.send(ctx, signal);
-        this.updatedAt = Date.now();
-
-        const result = this.applyData(freshData, true);
-        this.saveQueryMetadata();
-
-        this.reconcileSubscription();
-
-        return result;
+        try {
+          const freshData = await adapter.send(ctx, signal);
+          this.updatedAt = Date.now();
+
+          const result = this.applyData(freshData, true);
+          this.saveQueryMetadata();
+
+          return result;
+        } finally {
+          this.reconcileSubscription();
+        }
       },

On adapter-level failures where ctx.response was never updated this is a no-op: _resolvedOptions returns its cached value, the subscribe ref hasn't changed, and the ref check inside reconcileSubscription short-circuits.

Why the existing test missed this

stops polling when getConfig() switches subscribe to undefined after an error used result = { n: t.number } with a 404 body of { n: callCount }. The body matched the result schema, applyData succeeded, and the reconcile path ran normally. The test passed even though the bug was present for the entity-shape-mismatch case.

That test is rewritten to use t.entity() with a 404 body that does not match the entity shape ({error: 'Not found'}). It fails on main and passes with this change.

Test plan

• Repro test fails on main, passes with the fix
• Full unit suite: 1135 passed, 2 skipped
• Manual verification by a consumer that hit this in a runtime where the existing test's "lucky" body shape didn't paper over the bug

🤖 Generated with Claude Code