chore: plugin declared MIT while the project is All Rights Reserved - #15
Merged
Conversation
.claude-plugin/plugin.json declared "license": "MIT". The project is All Rights Reserved, so left as-is the plugin directory arguably shipped under MIT terms — granting rights the rest of the project reserves, and contradicting the CLA every contributor signs. Now "Proprietary — All Rights Reserved", matching signetry-core's pyproject.toml wording. Checked for other MIT claims: no LICENSE file exists here and GitHub detects no license, so this declaration was the only one.
Contributor
Signetry Reviewer — 🟡 Needs human reviewA human should decide — the required check is unknown. Deterministic gates (the authority)
FindingsNo issues found by the deterministic scanners. MergeA human should review and merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claude-code/signetry/.claude-plugin/plugin.jsondeclared:The project is All Rights Reserved. Left as-is, the plugin directory arguably shipped under MIT terms — granting rights the rest of the project explicitly reserves, and contradicting the CLA every contributor signs. Now:
Matching
signetry-core'spyproject.tomlwording, so the two agree.Scope check
I looked for other MIT claims rather than assuming this was the only one:
LICENSE/LICENSE.mdfilenone.claude-plugin/marketplace.jsonlicensefieldpyproject.toml/package.jsonSo this declaration was the only one. JSON re-parsed after the edit to confirm it's still valid.
The same declaration exists in
Signetry/claude-code(the split-out repo) and is fixed there in a matching PR.