Fix key rotation bugs, support multi-user rotation, and improve logging/notifications - #44
Merged
Conversation
haggaret
commented
Aug 13, 2026
Contributor
- Fix 1Password SDK usage: use list() instead of nonexistent list_all()/.obj (project/plugins/1password.py)
- Fix SSH key loading to use paramiko's PKey.from_path for broader format support, with a fallback for RFC 5958 v2 Ed25519 keys that the bundled cryptography release fails to parse (project/plugins/ssh.py)
- Add HTTP status/body to Pingdom and Bitbucket API failure logs instead of swallowing the actual error (project/plugins/pingdom.py, bitbucket.py)
- Fix mail notifications: broken logo image, literal/unrendered newlines, unclickable URLs, and a stale office address (project/plugins/mail.py, notification-email.html)
- Name threads after the user/function they're running so crash tracebacks are attributable (project/utils.py)
- Support rotating/listing/validating multiple users via -u/--users (comma-separated), replacing the old singular --user flag; validate action no longer uses threading (project/main.py, README.md)
- Log which account/profile credentials were written to in parameter store, and clean up leftover debug print() statements (project/plugins/iam.py)
…ng/notifications - Fix 1Password SDK usage: use list() instead of nonexistent list_all()/.obj (project/plugins/1password.py) - Fix SSH key loading to use paramiko's PKey.from_path for broader format support, with a fallback for RFC 5958 v2 Ed25519 keys that the bundled cryptography release fails to parse (project/plugins/ssh.py) - Add HTTP status/body to Pingdom and Bitbucket API failure logs instead of swallowing the actual error (project/plugins/pingdom.py, bitbucket.py) - Fix mail notifications: broken logo image, literal/unrendered newlines, unclickable URLs, and a stale office address (project/plugins/mail.py, notification-email.html) - Name threads after the user/function they're running so crash tracebacks are attributable (project/utils.py) - Support rotating/listing/validating multiple users via -u/--users (comma-separated), replacing the old singular --user flag; validate action no longer uses threading (project/main.py, README.md) - Log which account/profile credentials were written to in parameter store, and clean up leftover debug print() statements (project/plugins/iam.py)
…t and then prompting each one
ryan-j-mci
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.