Fix JS-0116 warnings in wiki-data-manager ensureIndex#9
Merged
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
Mar 27, 2026 12:34p.m. | Review ↗ |
| Shell | |
Mar 27, 2026 12:34p.m. | Review ↗ |
| JavaScript | |
Mar 27, 2026 12:34p.m. | Review ↗ |
| Swift | |
Mar 27, 2026 12:34p.m. | Review ↗ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve DeepSource JS-0116 warnings by removing an unnecessary async modifier from ensureIndex in both platform copies of wiki-data-manager.js.
Changes:
- Removed
asyncfromensureIndex()in the iOS script copy. - Removed
asyncfromensureIndex()in the MOS script copy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mos/Flean Extension/Resources/scripts/wiki-data-manager.js | Removes async from ensureIndex() to address JS-0116 warning. |
| ios/extention/Resources/scripts/wiki-data-manager.js | Removes async from ensureIndex() to address JS-0116 warning. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kiyarose
merged commit Mar 27, 2026
c45f702
into
copilot/implement-remote-wiki-data-loading
5 checks passed
kiyarose
deleted the
codex/fix-async-functions-without-await-in-javascript
branch
March 27, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
asyncmodifier fromensureIndexto resolve DeepSourceJS-0116findings in both platform script copies.Description
async function ensureIndex () {withfunction ensureIndex () {inios/extention/Resources/scripts/wiki-data-manager.jsandmos/Flean Extension/Resources/scripts/wiki-data-manager.js, preserving the original promise-based behavior.Testing
node --check ios/extention/Resources/scripts/wiki-data-manager.jsandnode --check "mos/Flean Extension/Resources/scripts/wiki-data-manager.js", and both checks passed.Codex Task