Skip to content

Resolve PR review feedback and unblock GitHub Pages preview deploy#256

Merged
kiyarose merged 8 commits into
mainfrom
copilot/fix-review-comments-and-job-failure
May 13, 2026
Merged

Resolve PR review feedback and unblock GitHub Pages preview deploy#256
kiyarose merged 8 commits into
mainfrom
copilot/fix-review-comments-and-job-failure

Conversation

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

This PR addresses outstanding review feedback on the Astro migration branch and removes the deploy-time blocker in the PR preview workflow. Scope is limited to base-path correctness, static output collisions, and workflow permission alignment.

  • Base-path correctness in runtime data and metadata

    • Remote snapshot fetch path now derives from import.meta.env.BASE_URL instead of a root-absolute path, so sub-path deployments (e.g. Pages) resolve correctly.
    • Reintroduced favicon metadata in BaseLayout using a base-aware href.
    • Updated navigation comments to match current behaviour (window.location.assign), removing stale pushState references.
  • Static output collision removal

    • Moved fallback page from public/index.html to public/fallback/index.html to avoid overwriting Astro-generated /index.html.
    • Updated repository references that pointed to the old fallback location.
  • Dependency surface cleanup

    • Removed unused direct dependency zod from package.json (and lockfile).
  • Preview deploy workflow unblock

    • Added pull-requests: write to .github/workflows/github-pages-preview.yml permissions to support PR preview deployment operations.
// src/hooks/useRemoteData.ts
const REMOTE_DATA_PATH = `${import.meta.env.BASE_URL}__remote-data`;
const response = await fetch(`${REMOTE_DATA_PATH}/${resource}.json`, { /* ... */ });
# .github/workflows/github-pages-preview.yml
permissions:
  contents: read
  pages: write
  id-token: write
  pull-requests: write

cursoragent and others added 8 commits May 13, 2026 05:09
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/Portf/sessions/347cdca7-8283-4c28-ad63-8d83605460cb

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/Portf/sessions/347cdca7-8283-4c28-ad63-8d83605460cb

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants