Skip to content

donate: follow system theme instead of forcing dark mode#21

Merged
kiyarose merged 7 commits intomainfrom
copilot/force-system-theme-donation-page
Mar 19, 2026
Merged

donate: follow system theme instead of forcing dark mode#21
kiyarose merged 7 commits intomainfrom
copilot/force-system-theme-donation-page

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

  • Explore codebase (donate.html, theme.js, base.css)
  • Remove hard-coded data-theme="dark" from <html> tag
  • Replace "force dark" script with system theme detection via prefers-color-scheme
  • Add matchMedia change listener to stay in sync if OS theme changes while page is open
  • Keep theme toggle blocked with shake animation + "Theme switching is unsupported on this page." toast unchanged
  • Fix head early-init script to read prefers-color-scheme only — no localStorage — so page and iframe start in the same mode with no FOUC

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@deepsource-io
Copy link
Copy Markdown
Contributor

deepsource-io bot commented Mar 18, 2026

DeepSource Code Review

We reviewed changes in b3ed038...84e0a47 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Secrets Mar 19, 2026 11:17a.m. Review ↗
Shell Mar 19, 2026 11:17a.m. Review ↗
JavaScript Mar 19, 2026 11:17a.m. Review ↗

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 18, 2026

Deploying kvgrow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84e0a47
Status: ✅  Deploy successful!
Preview URL: https://b5b43054.kvgrow.pages.dev
Branch Preview URL: https://copilot-force-system-theme-d.kvgrow.pages.dev

View logs

Copilot AI changed the title [WIP] Update donation page to match user system theme donate: follow system theme instead of forcing dark mode Mar 18, 2026
Copilot AI requested a review from kiyarose March 18, 2026 17:47
@kiyarose kiyarose added this to the Modernize_r1 milestone Mar 19, 2026
@kiyarose kiyarose marked this pull request as ready for review March 19, 2026 09:36
Copilot AI review requested due to automatic review settings March 19, 2026 09:36
Copy link
Copy Markdown
Member

@kiyarose kiyarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should have used computer so I can test in live, but it does not break anything which is the most important.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the donation page’s theming so it follows the user’s OS prefers-color-scheme (to stay consistent with the embedded HCB donation iframe) while continuing to block manual theme toggling on that page.

Changes:

  • Removed the hard-coded data-theme="dark" from <html>.
  • Added a system-theme override script using matchMedia('(prefers-color-scheme: dark)'), including live OS-theme change syncing.
  • Kept the “toggle lock” behavior by clone-replacing the toggle element to drop theme.js’s click listener.

You can also share your feedback on Copilot code review. Take the survey.

@kiyarose
Copy link
Copy Markdown
Member

@copilot apply changes based on the comments in this thread

This comment was marked as spam.

5 similar comments

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

kiyarose and others added 4 commits March 19, 2026 07:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit fixes the style issues introduced in 04d1db2 according to the output
from Prettier and StandardJS.

Details: #21
@kiyarose kiyarose requested a review from Copilot March 19, 2026 11:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the donate.html page theme behavior so it follows the user’s OS prefers-color-scheme (to match the embedded HCB donation iframe) rather than forcing dark mode.

Changes:

  • Removed the hard-coded data-theme="dark" from the <html> element.
  • Added early theme initialization in <head> and a post-load override that applies system theme and live-syncs via matchMedia change events.
  • Kept “theme toggle lock” behavior by cloning/replacing the toggle element and showing the existing toast + shake animation.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Copilot AI requested a review from kiyarose March 19, 2026 11:17
@kiyarose kiyarose merged commit f59527c into main Mar 19, 2026
5 checks passed
@kiyarose kiyarose deleted the copilot/force-system-theme-donation-page branch March 19, 2026 14:02
kiyarose added a commit that referenced this pull request Mar 29, 2026
* donate: follow system theme instead of forcing dark mode (#21)

* Initial plan

* fix: follow system theme on donate page instead of forcing dark mode

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* style: format code with Prettier and StandardJS

This commit fixes the style issues introduced in 04d1db2 according to the output
from Prettier and StandardJS.

Details: #21

* fix: head script uses only system theme, no localStorage, on donate page

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Switch primary font to Lexend and refine typography weights (#22)

* Switch primary font to Lexend and keep footer in SLF Dreamer

Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

* Increase button font weight and lighten Tech wordmark

Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

* style: format code with Prettier and StandardJS

This commit fixes the style issues introduced in 3e8c457 according to the output
from Prettier and StandardJS.

Details: #22

* Move Google Fonts to `<link>` preconnect and fix "Tech" wordmark font (#24)

* Initial plan

* perf: move Google Fonts to link preconnect and fix Tech wordmark font

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* docs: add comment to base.css noting Lexend must be loaded via link in HTML head

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix regex security hotspot in brand.html; deduplicate theme-toggle markup (#25)

* Initial plan

* fix: address regex security hotspot in brand.html and deduplicate theme-toggle markup

- brand.html: change lazy quantifier [^&]*? to greedy [^&]* in highlightHtml
  regex; add comment noting input is machine-generated (not user input) so ReDoS
  is not a concern
- theme.js: add injectThemeToggleButton() so the button is defined in one place;
  init() now injects it automatically when #themeToggle is absent
- index.html, apply.html, donate.html, brand.html: remove 38-line duplicated
  theme-toggle <button> block from each file (replaced with a brief comment)

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/d607b3be-436a-4aac-9f9f-13f8be74a195

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Create dependabot.yml for version updates

Add initial configuration for Dependabot updates.

* Fix copy button hidden behind codebox on brand page (#29)

* Initial plan

* Fix: Move copy button inside codebox to fix visibility on brand page

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/95786c2e-8426-4962-9e32-0a5d8b95169d

* Fix copy button: solid background, outside scroll container, clean up duplicate CSS rule

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a3f820f0-13cd-462d-99b7-6f488c044450

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Set package ecosystem to 'npm' in dependabot config

* Fix FOUC on Contact Us page and resolve SonarCloud maintainability warnings (#31)

* Initial plan

* Fix: add anti-FOUC theme script to apply.html head

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a98d089c-ab11-4c4b-a4fa-7650d3896cd8

* Fix SonarCloud empty catch block warning in anti-FOUC scripts

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/6f4b51b7-2269-4f71-ae73-973284fcaffc

* Fix SonarCloud unused catch binding in anti-FOUC scripts (use optional catch binding)

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a28f3a6f-996a-4016-8937-3b1ac822baa6

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* fix: resolve 53 SonarCloud code smells across 6 files (#27)

* Initial plan

* fix: resolve 53 SonarCloud code smells across brand.css, brand.html, donate.html, index.html, script.js, theme.js

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/c16e496a-1317-4d1b-8e22-e77d44847609

* Changes before error encountered

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/6ab0c607-d2b4-4328-b631-5e9ab7d8bab2

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Add package.json listing all project dependencies (#32)

Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/4be40485-ef5d-4df0-a8f7-ba0e3df5456a

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Create CNAME

* Delete CNAME

* Replace contributor links with Projects page; add floating contributor profile icons (#36)

* Initial plan

* Modernize links: add projects link, contributor profile icons

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a574598b-7edf-4eb0-aa1e-5a759150361d

* Move contributor icons to contributors.json, load dynamically

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/dfe39997-dff4-4df4-a515-5832beec1d91

* Move contributor icons above links in right section

Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/c06585fb-4ad8-402f-bfbe-eb9b2a46e50c

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* enhance: better terminology on apply page (#37)

Apply page now better serves as a versatile contact us page.
The terminology on this page now better serves any possible reason for contact, and is welcoming to projects of all types.

* Update redirects and apply page header (#38)

* Update _redirects with new project links

Added new redirects for various projects and contributions.

* Update title and header for apply.html

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants