Skip to content

Replace contributor links with Projects page; add floating contributor profile icons#36

Merged
kiyarose merged 4 commits intomainfrom
copilot/modernize-project-contrib-links
Mar 26, 2026
Merged

Replace contributor links with Projects page; add floating contributor profile icons#36
kiyarose merged 4 commits intomainfrom
copilot/modernize-project-contrib-links

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

  • Create contributors.json with the two existing contributor entries (url, avatar, name, label)
  • Add renderContributors() to script.js — fetches the JSON and builds the icon anchors dynamically
  • Replace hardcoded contributor <a> tags in index.html with an empty #contributorsContainer div
  • Call renderContributors('#contributorsContainer', 'contributors.json') in the DOMContentLoaded handler
  • Move contributor icons panel above the links list in the right section (per @kiyarose feedback)
Original prompt

This section details on the original issue you should resolve

<issue_title>Task: Modernize Project page links & Contrib Links</issue_title>
<issue_description>Right now the main page of sillylittle.tech simply lists the websites of me and Krystal, the two main contributors and examples of templates made.
Now, https://projects.sillylittle.tech links to our GitHub Pages (Repo), we should make a separate page (and link to such) for us contributors (and hopefully future ones), and link to the aforementioned projects page, which we can then later fill with links to individual projects.
Additonally, we should add a page that will host previews of our templates, and possibly live demos if we can get up and running. </issue_description>

<agent_instructions>The page mentioned on https://projects.sillylittle.tech is set up. In the links JSON file, replace existing entries linking to that.
Please make floating profile picture icons of the existing website linked in the links JSON file, kiyaGH profile picture "https://avatars.githubusercontent.com/u/75678535?v=4", krystalGH profile picture "https://avatars.githubusercontent.com/u/32627918?v=4", they should be round. Put them out of the way, but noticeable, make sure they do not clutter any other buttons. </agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@deepsource-io
Copy link
Copy Markdown
Contributor

deepsource-io bot commented Mar 26, 2026

DeepSource Code Review

We reviewed changes in 0cec436...99966c4 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Secrets Mar 26, 2026 6:33p.m. Review ↗
Shell Mar 26, 2026 6:33p.m. Review ↗
JavaScript Mar 26, 2026 6:33p.m. Review ↗

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 26, 2026

Deploying kvgrow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99966c4
Status: ✅  Deploy successful!
Preview URL: https://a8aac309.kvgrow.pages.dev
Branch Preview URL: https://copilot-modernize-project-co.kvgrow.pages.dev

View logs

Copilot AI changed the title [WIP] Update project links and add contributors page Replace contributor links with Projects page; add floating contributor profile icons Mar 26, 2026
Copilot AI requested a review from kiyarose March 26, 2026 12:18
Copy link
Copy Markdown
Member

@kiyarose kiyarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contributors panel is in a weird location, can we move it above the projects link, as shown in the image. attached.

Image

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

The contributors panel is in a weird location, can we move it above the projects link, as shown in the image. attached.

<img width="1454" height="700" alt="Image" src="https://github.com/user-attach...

Moved the contributor icons into the right section, above the links list, in commit 99966c4. They now display as a horizontal row of rounded avatars directly above the Projects link.

@sonarqubecloud
Copy link
Copy Markdown

Copilot AI requested a review from kiyarose March 26, 2026 18:33
@kiyarose kiyarose marked this pull request as ready for review March 26, 2026 19:13
Copilot AI review requested due to automatic review settings March 26, 2026 19:13
@kiyarose kiyarose merged commit 2e6e76d into main Mar 26, 2026
11 checks passed
@kiyarose kiyarose deleted the copilot/modernize-project-contrib-links branch March 26, 2026 19:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the landing page link list to point to the Projects site and replaces the previously hardcoded contributor links with dynamically rendered contributor avatar icons loaded from a new JSON file.

Changes:

  • Replace the existing contributor/portfolio entries in links.json with a single “Projects” link.
  • Add contributors.json and client-side rendering (renderContributors) to populate contributor avatar links.
  • Add landing-page CSS and HTML scaffolding for the contributor icon strip above the links list.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
site.css Adds styles for the contributor icon strip and round avatar link presentation.
script.js Adds renderContributors() and calls it on DOMContentLoaded to fetch/render contributors.json.
links.json Replaces contributor links with a single external “Projects” entry.
index.html Replaces hardcoded contributor anchors with an empty #contributorsContainer for JS rendering.
contributors.json Introduces contributor metadata (name/url/avatar/label) used by the new renderer.

Comment on lines +108 to +111
const img = document.createElement('img')
img.src = contributor.avatar || ''
img.alt = contributor.name || ''

Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img.src is set to an empty string when contributor.avatar is missing. An empty src is treated as a (relative) URL and may trigger an unintended request for the current document and show a broken image. Prefer omitting the <img>/skipping the contributor when avatar is missing, or providing a real placeholder image.

Copilot uses AI. Check for mistakes.
Comment on lines +116 to +120
.catch((err) => {
const msg = err?.message ?? 'unknown error'
console.error('Error rendering contributors:', err)
debugLog(`renderContributors error: ${msg}`)
})
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On fetch/render failure, contributor icons fail silently in the UI (only console/debug logs). renderLinks shows a visible error message and renderFooter restores static content; consider adding a similar fallback for contributors (e.g., keep existing markup if present, or render a small non-intrusive error/placeholder) so users aren’t left with an unexplained empty area.

Copilot uses AI. Check for mistakes.
Comment on lines +161 to +167
/* Contributor profile icons — displayed above the links list in the right section */
.contributor-icons {
display: flex;
flex-direction: row;
gap: 10px;
margin-bottom: 16px;
}
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/issue request calls these “floating” profile icons and asks that they be “out of the way”, but the current styles lay them out inline in the normal document flow above the links list (no fixed/absolute positioning). If floating behavior is still required, adjust the CSS to position the panel (and ensure it doesn’t overlap the theme toggle/buttons) or update the PR title/description to match the implemented non-floating layout.

Copilot uses AI. Check for mistakes.
Comment on lines +101 to +103
const anchor = document.createElement('a')
anchor.className = 'contributor-icon'
anchor.href = contributor.url || '#'
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renderContributors sets anchor.href to '#' when contributor.url is missing but still forces target="_blank". This can open a useless blank tab (and # can also jump to the top if opened in-page). Prefer skipping entries without a valid URL, or only setting target/rel when the URL is present and external.

Suggested change
const anchor = document.createElement('a')
anchor.className = 'contributor-icon'
anchor.href = contributor.url || '#'
// Skip contributors without a valid URL to avoid creating useless "#" links.
if (!contributor.url) {
debugLog('renderContributors: skipping contributor without URL')
return
}
const anchor = document.createElement('a')
anchor.className = 'contributor-icon'
anchor.href = contributor.url

Copilot uses AI. Check for mistakes.
kiyarose added a commit that referenced this pull request Mar 29, 2026
* donate: follow system theme instead of forcing dark mode (#21)

* Initial plan

* fix: follow system theme on donate page instead of forcing dark mode

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* style: format code with Prettier and StandardJS

This commit fixes the style issues introduced in 04d1db2 according to the output
from Prettier and StandardJS.

Details: #21

* fix: head script uses only system theme, no localStorage, on donate page

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Switch primary font to Lexend and refine typography weights (#22)

* Switch primary font to Lexend and keep footer in SLF Dreamer

Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

* Increase button font weight and lighten Tech wordmark

Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>

* style: format code with Prettier and StandardJS

This commit fixes the style issues introduced in 3e8c457 according to the output
from Prettier and StandardJS.

Details: #22

* Move Google Fonts to `<link>` preconnect and fix "Tech" wordmark font (#24)

* Initial plan

* perf: move Google Fonts to link preconnect and fix Tech wordmark font

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* docs: add comment to base.css noting Lexend must be loaded via link in HTML head

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Co-authored-by: Kiya Rose Ren-Miyakari <kiya.rose@sillylittle.tech>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix regex security hotspot in brand.html; deduplicate theme-toggle markup (#25)

* Initial plan

* fix: address regex security hotspot in brand.html and deduplicate theme-toggle markup

- brand.html: change lazy quantifier [^&]*? to greedy [^&]* in highlightHtml
  regex; add comment noting input is machine-generated (not user input) so ReDoS
  is not a concern
- theme.js: add injectThemeToggleButton() so the button is defined in one place;
  init() now injects it automatically when #themeToggle is absent
- index.html, apply.html, donate.html, brand.html: remove 38-line duplicated
  theme-toggle <button> block from each file (replaced with a brief comment)

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/d607b3be-436a-4aac-9f9f-13f8be74a195

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Create dependabot.yml for version updates

Add initial configuration for Dependabot updates.

* Fix copy button hidden behind codebox on brand page (#29)

* Initial plan

* Fix: Move copy button inside codebox to fix visibility on brand page

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/95786c2e-8426-4962-9e32-0a5d8b95169d

* Fix copy button: solid background, outside scroll container, clean up duplicate CSS rule

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a3f820f0-13cd-462d-99b7-6f488c044450

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Set package ecosystem to 'npm' in dependabot config

* Fix FOUC on Contact Us page and resolve SonarCloud maintainability warnings (#31)

* Initial plan

* Fix: add anti-FOUC theme script to apply.html head

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a98d089c-ab11-4c4b-a4fa-7650d3896cd8

* Fix SonarCloud empty catch block warning in anti-FOUC scripts

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/6f4b51b7-2269-4f71-ae73-973284fcaffc

* Fix SonarCloud unused catch binding in anti-FOUC scripts (use optional catch binding)

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a28f3a6f-996a-4016-8937-3b1ac822baa6

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* fix: resolve 53 SonarCloud code smells across 6 files (#27)

* Initial plan

* fix: resolve 53 SonarCloud code smells across brand.css, brand.html, donate.html, index.html, script.js, theme.js

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/c16e496a-1317-4d1b-8e22-e77d44847609

* Changes before error encountered

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/6ab0c607-d2b4-4328-b631-5e9ab7d8bab2

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Add package.json listing all project dependencies (#32)

Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/4be40485-ef5d-4df0-a8f7-ba0e3df5456a

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* Create CNAME

* Delete CNAME

* Replace contributor links with Projects page; add floating contributor profile icons (#36)

* Initial plan

* Modernize links: add projects link, contributor profile icons

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/a574598b-7edf-4eb0-aa1e-5a759150361d

* Move contributor icons to contributors.json, load dynamically

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/dfe39997-dff4-4df4-a515-5832beec1d91

* Move contributor icons above links in right section

Agent-Logs-Url: https://github.com/SillyLittleTech/lander/sessions/c06585fb-4ad8-402f-bfbe-eb9b2a46e50c

Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>

* enhance: better terminology on apply page (#37)

Apply page now better serves as a versatile contact us page.
The terminology on this page now better serves any possible reason for contact, and is welcoming to projects of all types.

* Update redirects and apply page header (#38)

* Update _redirects with new project links

Added new redirects for various projects and contributions.

* Update title and header for apply.html

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Modernize Project page links & Contrib Links

3 participants