Specify GCC and clang-format versions in Github runners #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdorn
approved these changes
Mar 11, 2025
Contributor
ncdorn
left a comment
ncdorn
left a comment
There was a problem hiding this comment.
Looks good and a bit more robust than before
1 task
rjrios915
added a commit
to rjrios915/svZeroDSolver
that referenced
this pull request
Mar 13, 2025
Specify GCC and clang-format versions in Github runners (SimVascular#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Closes #147
Release Notes
Updated dependencies to use GCC 13 on both MacOS and Ubuntu.
Updated upload-artifact@v3 to upload-artifact@v4
Fixed clang-format to version 19.
Note that brew installs clang-format version 20 by default on MacOS and I am still seeing some differences in the clang-format output between the Github runner and my local Mac (presumably because of the version 19 on Ubuntu v/s version 20 on Mac, but not sure). It would be great to resolve this but I haven't been able to install clang-format 20 on the Ubuntu runner. An alternative is to make the test fail only if clang-format fails on BOTH Ubuntu and MacOS. That way we will have fewer tests failing just because of differences in the two systems.
Documentation
N/A
Testing
All tests pass.
Code of Conduct & Contributing Guidelines