[pull] master from getsentry:master#249
Merged
pull[bot] merged 4 commits intoSimenB:masterfrom Aug 1, 2025
Merged
Conversation
…nd mark them as symbolicated to stop getting a warning (#96828) Context: In Dart, `<asynchronous suspension>` frames are synthetic markers inserted by the runtime to indicate where an async function was suspended while waiting for a Future to complete. They don't represent actual executable code ## Before: Shows a warning and is visible in `most relevant` frames <img width="875" height="208" alt="image" src="https://github.com/user-attachments/assets/df16ada5-577f-44b8-aa58-a1e8b6b927bb" /> ## After: Hide it for most relevant frames <img width="875" height="178" alt="Screenshot 2025-07-31 at 08 12 32" src="https://github.com/user-attachments/assets/bb84e80a-50db-41d1-8740-35e9b89a6d60" /> Show it on full stacktrace and also sanitize it a little bit so it doesnt show up as a warning <img width="875" height="208" alt="Screenshot 2025-07-31 at 08 12 40" src="https://github.com/user-attachments/assets/21634a39-fd0c-47b7-b4d5-e4691045d959" /> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
We have overrides that force the option to 100%, in order to be able to remove the overrides the default needs to be 100% first. Longterm: Delete the option -> getsentry/relay#5008
This changes Apple crash report generation so that all addresses in frames and debug images are parsed only once when the AppleCrashReport object is first created, instead of every time they are accessed. Furthermore, it also constructs a map from debug images' `image_addr`s to `image_vmaddr` during creation. The method `_get_slide_value` then becomes a simple lookup in this map instead of a linear search through all debug images. Additionally, there are some minor improvements such as `get`ting values out of dictionaries only once. ref: INGEST-454. --------- Co-authored-by: Simon Hellmayr <shellmayr@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )