[pull] master from getsentry:master#403
Merged
pull[bot] merged 8 commits intoSimenB:masterfrom Oct 2, 2025
Merged
Conversation
…e filter (#97675) I made a poc to see how `nuqs` would work in the sentry code-base, here are a couple of take-aways: 1. It’s way less code, updating is literally just calling `setState` and it works. 2. Types are inferred from the `parser` rather than asserted, so we no longer have `location.query.issuesType as IssuesType`. 3. It will fall-back to the default if you have an un-parsable value in the url, so `?issuesType=asdf` just becomes the default vs. right now, we actually work with that wrong value. 4. It will remove the default value from the query (unless opted out with `clearOnDefault: false`). This is nice because it doesn’t pollute the url with values we don’t need anyhow. 5. `nuqs` performs [shallow routing per default in react-router based frameworks](https://nuqs.47ng.com/docs/options#in-react-router-based-frameworks). That means that components that are not interested in a certain query param will not re-render. This can potentially lead to a much snappier interaction, e.g. compare this before and after video with highlighted re-renders when changing the `issueType`. 5.1 note: for now, I’ve set `shallow:false` globally, which voids this advantage, but we can tweak this once we no longer read from `useLocation` directly. before: https://github.com/user-attachments/assets/ef9ffcbf-fb96-475d-9ac7-da805f3a3b84 after: https://github.com/user-attachments/assets/98d39929-1a18-4ea3-9a2f-bb06cb1acf25 This could be a huge upside, but one downside of course is that if we still have places left that subscribe to this param via `useLocation().query`, they wouldn’t read the latest value after an update. That means we either need to opt out with `shallow:false` in those cases, or migrate all usages of the same param everywhere at the same time.
Populate `has_ever_sent_data` on the generic insights pageload event for agent monitoring.
In UI2, the input already has a darker background color, so just applying another background color for focussing isn’t enough signal to the user. As per the suggestion of @natemoo-re, we’re now also applying an accent border color. This applies to both when pressing `cmd-A` to select all filters, as well as pressing backspace to focus the last filter. In this comparison, `age` is focused. Especially in light mode, this was almost invisible: | before | after | |--------|--------| | <img width="594" height="141" alt="Screenshot 2025-09-26 at 14 01 20" src="https://github.com/user-attachments/assets/f489f884-341c-4f32-810c-c6cd74ce6eb5" /> | <img width="610" height="127" alt="Screenshot 2025-09-26 at 14 02 03" src="https://github.com/user-attachments/assets/1ff85d83-c2b8-48bf-9e1e-c988ecfe7561" /> | | <img width="577" height="130" alt="Screenshot 2025-09-26 at 14 01 28" src="https://github.com/user-attachments/assets/f3b107e0-f7eb-435c-adb9-12e0c860cdf4" /> | <img width="611" height="124" alt="Screenshot 2025-09-26 at 14 01 55" src="https://github.com/user-attachments/assets/343e531e-5e74-4fb2-9e42-084a9f1a4816" /> |
…100768) Add inline instructions for sending input and output attributes for `gen_ai` spans that are missing those. The alert detects which sdk + integration was used and displays instructions accordingly. The alert may be shown only on spans that support input / output (`gen_ai.invoke_agent`, `gen_ai.execute_tool` & any generation span) Dismissing the alert is permanent action.
…#100295) Change TTL to 7d instead of 1h. We only ever mark tasks as completed here, so it is fine if we cache it for longer period of time, as this should reduce the load on our database, and once resolved, this task doesn't need to be updated again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )