Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
targetLinkLibrariesWithDynamicLookup: Backport module from scikit-build #80
I don't see a replacement for this variable. Any suggestions on how to update the behavior?
When using manylinux, the following is done:
This allows to keep
What is missing from the solution of marking a find language library as QUIET, and then not linking against it?
The prior solution does not include a check to ensure linking does not occur, but it does not require custom configuration when a system or language is encountered without the libraries. The problem ( or purposeful intent ) of language development packages not including libraries has occurred several time in the real world ( outside of building on manylinux). It is necessary to continue supporting these systems output the box.
An improved solution to the existing one is welcomed, if it meets the requirements.
Looking at your previous link, I missed the part where it doesn't link against it. It looks like this is done in function
It turns out that the implementation of that same function in scikit-build also conditionally links against the python library. We are good on that front.
The problem is in two locations:
For the problem (1), changing that code from
should address the issue.
Similarly to the other CMake modules, I will make sure it is documented on read the docs.
In the mean time, associated documentation is here: https://github.com/scikit-build/scikit-build/blob/d592c8084a7e0502d9da9e7aacf0e465be40cc67/skbuild/resources/cmake/targetLinkLibrariesWithDynamicLookup.cmake#L61-L92
For the problem (2) in
should be changed into