Skip to content

! backport some SCeditor 1.4 fixes to 1.3.7 - #222

Merged
emanuele45 merged 1 commit into
SimpleMachines:release-2.1from
Spuds:scBackport
Oct 25, 2012
Merged

! backport some SCeditor 1.4 fixes to 1.3.7#222
emanuele45 merged 1 commit into
SimpleMachines:release-2.1from
Spuds:scBackport

Conversation

@Spuds

@Spuds Spuds commented Oct 23, 2012

Copy link
Copy Markdown
Contributor

! Fix bug when pasting from Word
! Fixed bug causing scrollbar to change when inserting BBCode in source mode
! Fixed bug causing cursor position to be lost in FF when getting the editors value

Signed-off-by: Spuds spuds@simplemachines.org

! Fix bug when pasting from Word
! Fixed bug causing scrollbar to change when inserting BBCode in source mode
! Fixed bug causing cursor position to be lost in FF when getting the editors value

Signed-off-by: Spuds <spuds@simplemachines.org>
@norv

norv commented Oct 24, 2012

Copy link
Copy Markdown
Contributor

Thank you! By the looks of it, there may be some work at every update.

@Spuds

Spuds commented Oct 24, 2012

Copy link
Copy Markdown
Contributor Author

Most likely yes ... Updates/fixes are only going in to the new 1.4 branch with is still under development. Depending on when that goes final we can discuss if its right update 2.1 to the latest level or leave things alone. Right now I'm thinking of waiting until the 1.4.1 branch is out which is supposed to provide a way to add events to the editor ... now what we have to do for this is ... well kind of ugly.

@emanuele45

Copy link
Copy Markdown
Contributor

now what we have to do for this is ... well kind of ugly.

Nothing new, I coded it! :P

emanuele45 added a commit that referenced this pull request Oct 25, 2012
! backport some SCeditor 1.4 fixes to 1.3.7
@emanuele45
emanuele45 merged commit 5e05031 into SimpleMachines:release-2.1 Oct 25, 2012
@Spuds

Spuds commented Oct 26, 2012

Copy link
Copy Markdown
Contributor Author

Nothing new, I coded it! :P

Nah, that one is really the editors issue ... having to dig down to find the iframe which misbehaves anyway, is the ugly part ;) Good enough for now, but when the editor itself supports event notifications things will be better (I hope)

Sesquipedalian pushed a commit that referenced this pull request Aug 3, 2026
Second group of tokens: the .button family, which the quickbuttons and the
inline moderation checkbox share the same rules with. Normal, hover, focus
and active states, plus the border, radius, shadow, cursor, font size, text
transform and the text shadow the active button carries.

As with the first group, every value is the one the rule already had, so
nothing changes on screen. The two hard-coded values left in these rules are
deliberate: .pagesection .button uses the body link colour rather than a
button colour, and the #222 in the shared hover rule only ever reaches the
quickbuttons, because the very next rule overrides it for .button. Neither
has an honest name in this vocabulary yet.

Verified two ways. Each of the nineteen tokens resolves to exactly the
literal it replaced, read back from :root in the browser. Then computed
styles for eleven button variants - plain, active, quickbutton, inline mod
check, first and last in a buttonrow, inside a cat_bar, smalltext, and the
three of those that can hold focus - across twenty properties. 220
comparisons, no differences.

Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants