[3.0] Theme split (wave 3, part 1) — Add the primary and secondary colour ramps - #9369
Open
albertlast wants to merge 1 commit into
Open
[3.0] Theme split (wave 3, part 1) — Add the primary and secondary colour ramps#9369albertlast wants to merge 1 commit into
albertlast wants to merge 1 commit into
Conversation
The remaining theme parts are built on two nine-step ramps derived from a single hue each, rather than on individually chosen colours. Adding them ahead of those parts keeps each of them to the tokens it actually introduces. Nothing references the ramps yet and no existing token is repointed at them, so this changes nothing that is rendered. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Aug 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 1 of wave 3 of the #7933 split. Adds the two colour ramps the rest of the theme is built on.
The theme branch does not pick its colours one at a time. It derives them from two nine-step ramps, each generated from a single hue, so that a forum can be re-tinted by changing one number.
release-3.0has no equivalent, because wave 2 deliberately kept every token at the literal value the rule already used.The ramps are internally consistent, which is worth checking rather than assuming:
#38546Bishsl(207, 31%, 32%), so hue 207 is right, and step 700 sits correctly between step 600 at 39% lightness and step 800 at 25%.#ff9400ishsl(35, 100%, 50%), so hue 35 is right, and step 500 sits between step 400 at 57% and step 600 at 49%.What this does not do
Nothing references the ramps, and no existing token is repointed at one.
--html-bgis still#3e5a78rather thanvar(--primary-color-900), and the same goes for every other token already in the file. Nothing rendered changes.Repointing the existing tokens at the ramp is a real visual change and deserves its own review, so it is not in here. This only puts the ramp in place so that the chrome parts that follow can express the tokens they add in terms of it instead of adding more hard-coded colours.
Issues References (Fixes|Related|Closes)
Related to #7933.