[3.0] Theme split (wave 4, part 6) — use logical properties in the direction-branching inline styles - #9391
Open
albertlast wants to merge 1 commit into
Conversation
Seven inline styles pick their side by hand:
style="margin-', Utils::$context['right_to_left'] ? 'right' : 'left', ': …"
which is what margin-inline-start and padding-inline-start already mean. The
values are unchanged; only the branch goes.
One of the seven never worked. The board list on the membergroup editor writes
style="margin-left 1em;"
with a space where the colon should be, so the declaration is dropped and the
nested boards under a parent are not indented at all. Converting it fixes that as
a side effect.
Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the split of #7933, wave 4 part 6.
Seven inline styles pick their side by hand:
which is what
margin-inline-startandpadding-inline-startalready mean. Thevalues are unchanged; only the branch goes. Six templates:
ManageBoards,ManageMaintenance,ManageMembergroups,Profile,Search.One of the seven never worked
The board list on the membergroup editor writes the declaration with a space where
the colon should be:
so the browser drops it and boards nested under a parent are not indented at all.
On
release-3.0, with a child and a grandchild board:margin-left 0em;0pxmargin-left 1em;0pxmargin-left 2em;0pxAfter:
margin-inline-start: 0em;0pxmargin-inline-start: 1em;13.33pxmargin-inline-start: 2em;26.67pxTesting
On a clean install with a child board and a grandchild board added.
Board manager,
?action=admin;area=manageboards— the indentation is byte forbyte what the ternary produced, and now flips without it:
padding-left: 5pxpadding-right: 5pxpadding-left: 35pxpadding-right: 35pxpadding-left: 65pxpadding-right: 65pxMembergroup editor as above.
composer lintis clean on all five files.I have deliberately not taken the theme branch's other change to the same line,
which moves the board manager's base indent from 5px to 10px. That is a visual
tweak and does not belong in a change that is otherwise value-for-value.
Issues References (Fixes|Related|Closes)
Related to #7933