[3.0] Fixes two issues in SMF\Actions\TopicRestore - #9516
Merged
Sesquipedalian merged 2 commits intoAug 14, 2026
Conversation
Sesquipedalian
commented
Aug 14, 2026
Member
- Uses correct JOIN syntax in some calls to User::loadCustom()
- In SMF\Actions\TopicRestore::mergePosts(), a call was made to SMF\User::loadCustom() in which the 'joins' element of the 'query_customizations' argument wasn't a complete JOIN statement. This causes an SQL syntax error. A similar issue was found in SMF\Actions\Admin\Subscriptions::modify().
- For both cases, this commit fixes the malformed JOIN statements.
- Casts to correct types when calling Actions\TopicRestore::mergePosts()
- In SMF\Actions\TopicRestore::execute(), the mergePosts() method was being passed a string rather than an integer, causing an error to occur.
- This has been fixed by casting the argument to int.
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.