Skip to content

[3.0] Fixes two issues in SMF\Actions\TopicRestore - #9516

Merged
Sesquipedalian merged 2 commits into
SimpleMachines:release-3.0from
Sesquipedalian:3.0/topicrestore
Aug 14, 2026
Merged

[3.0] Fixes two issues in SMF\Actions\TopicRestore#9516
Sesquipedalian merged 2 commits into
SimpleMachines:release-3.0from
Sesquipedalian:3.0/topicrestore

Conversation

@Sesquipedalian

Copy link
Copy Markdown
Member
  1. Uses correct JOIN syntax in some calls to User::loadCustom()
    • In SMF\Actions\TopicRestore::mergePosts(), a call was made to SMF\User::loadCustom() in which the 'joins' element of the 'query_customizations' argument wasn't a complete JOIN statement. This causes an SQL syntax error. A similar issue was found in SMF\Actions\Admin\Subscriptions::modify().
    • For both cases, this commit fixes the malformed JOIN statements.
  2. Casts to correct types when calling Actions\TopicRestore::mergePosts()
    • In SMF\Actions\TopicRestore::execute(), the mergePosts() method was being passed a string rather than an integer, causing an error to occur.
    • This has been fixed by casting the argument to int.

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 5 milestone Aug 14, 2026
@Sesquipedalian
Sesquipedalian merged commit bfbca5b into SimpleMachines:release-3.0 Aug 14, 2026
4 checks passed
@Sesquipedalian
Sesquipedalian deleted the 3.0/topicrestore branch August 14, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants