Skip to content

Conversation

@chihung93
Copy link
Contributor

Hi @tibbi , I have finished the support of Vietnamese - Telex

Feature:

  1. Added a Vietnam Telex in the Setting screen
  2. Added the telex extension (Reference: https://github.com/florisboard/florisboard/blob/aa00eb6e79081fb602c68e55b7d5e80bfe2ae322/app/src/main/assets/ime/keyboard/org.florisboard.composers/extension.json#L17)
  3. Using telex in Edit text.
    Thanks.

Demo:

Demo_telex.webm

import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_LARGE
import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_MEDIUM
import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_SMALL
import com.simplemobiletools.keyboard.helpers.LANGUAGE_VIETNAMESE_TELEX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess this import isnt needed anymore

}

try {
val inputStream: InputStream = context.assets.open(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ctrl + alt + L to format text, also avoid writing double empty lines like amove

}
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these empty lines too

}

setupEmojiPalette(toolbarColor = toolbarColor, backgroundColor = mBackgroundColor, textColor = mTextColor)
if(context.config.keyboardLanguage == LANGUAGE_VIETNAMESE_TELEX){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, format code to have proper spacing

@chihung93
Copy link
Contributor Author

Thanks for your feedback. I have fixed all issues. @tibbi

@tibbi tibbi merged commit 056ab4d into SimpleMobileTools:main Jun 27, 2023
@tibbi
Copy link
Contributor

tibbi commented Jun 27, 2023

looks great, thanks :)

@tranhongs0n
Copy link

tranhongs0n commented Jul 22, 2023

@chihung93, @tibbi Thank you all for adding Vietnamese to this app, but there are still many bugs and I almost can't use this keyboard to type Vietnamese. I hope everyone will consider testing it more thoroughly.

@tibbi
Copy link
Contributor

tibbi commented Jul 22, 2023

ok, will try improving it once we find someone that has experience with it :)

@dmitriy-chernysh
Copy link
Contributor

dmitriy-chernysh commented Oct 11, 2023

I see Vietnamese key layout (xml/keys_letters_....xml) is missing in the app #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants