-
-
Notifications
You must be signed in to change notification settings - Fork 123
Feature/add_Vietnamese_Telex #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hung <>
Signed-off-by: Hung <>
Signed-off-by: Hung <>
| import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_LARGE | ||
| import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_MEDIUM | ||
| import com.simplemobiletools.keyboard.helpers.KEYBOARD_HEIGHT_MULTIPLIER_SMALL | ||
| import com.simplemobiletools.keyboard.helpers.LANGUAGE_VIETNAMESE_TELEX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess this import isnt needed anymore
| } | ||
|
|
||
| try { | ||
| val inputStream: InputStream = context.assets.open(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ctrl + alt + L to format text, also avoid writing double empty lines like amove
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these empty lines too
| } | ||
|
|
||
| setupEmojiPalette(toolbarColor = toolbarColor, backgroundColor = mBackgroundColor, textColor = mTextColor) | ||
| if(context.config.keyboardLanguage == LANGUAGE_VIETNAMESE_TELEX){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, format code to have proper spacing
Signed-off-by: Hung <>
|
Thanks for your feedback. I have fixed all issues. @tibbi |
|
looks great, thanks :) |
|
@chihung93, @tibbi Thank you all for adding Vietnamese to this app, but there are still many bugs and I almost can't use this keyboard to type Vietnamese. I hope everyone will consider testing it more thoroughly. |
|
ok, will try improving it once we find someone that has experience with it :) |
|
I see Vietnamese key layout (xml/keys_letters_....xml) is missing in the app #256 |
Hi @tibbi , I have finished the support of Vietnamese - Telex
Feature:
Thanks.
Demo:
Demo_telex.webm