Fix 353: Change gravity internally from Left and Right to Start and End #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
should be good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
LeftandRightgravity with the properStartandEndequivalents to support RTL languages.Fixes #353: Aligning RTL text isn't working correctly.
Before the change, notes and checklists in the app were aligned to one side, either Left or Right (regardless of LTR or RTL of the language). This was inconsistent with the widgets, which were already using Start and End gravity (
widget_text_layout.xml).After the change to Start / End, both LTR and RTL languages can coexist in the same note / checklist.
The Alignment setting should not be needed anymore for RTL as it works out of the box. It still uses the Left & Right terms for simplicity and even swaps the labels for RTL languages. TBD if renaming them to something like "Default" and "Inverted" would make more sense.