Skip to content

Conversation

@esensar
Copy link
Contributor

@esensar esensar commented Jul 26, 2023

This is related to #641

@tibbi
Copy link
Contributor

tibbi commented Jul 26, 2023

  1. the dialog is always using full height, even if the bottom part is empty
  2. Lets also change the "Create a new note" to some rectangle too as the last item

@tibbi
Copy link
Contributor

tibbi commented Jul 26, 2023

and add a Cancel button at the bottom of the dialog. I like it in general though.

@tibbi
Copy link
Contributor

tibbi commented Jul 27, 2023

  1. lets remove the divider under the notes above Cancel
  2. make Create a new note somehow bigger, maybe add a colored Plus under it

@esensar
Copy link
Contributor Author

esensar commented Jul 27, 2023

I have added a plus below "Create a new note", but it doesn't look right to me. I also tried making the text larger on that card, but it still didn't feel right.

I will try to find other options to make it bigger and more noticeable, without making it weird.

@tibbi
Copy link
Contributor

tibbi commented Jul 27, 2023

nope, doesnt look good indeed :D try checking some other apps, how they do it

@esensar
Copy link
Contributor Author

esensar commented Jul 28, 2023

How about having a Create a new note button next to cancel button on the dialog?
notes-ui-extra-button

Or making the create a new note item span all columns:
notes-ui-full-span

@tibbi
Copy link
Contributor

tibbi commented Jul 30, 2023

not a fan of those and having it at the bottom wastes useful space. Have you researched other apps?

@esensar
Copy link
Contributor Author

esensar commented Jul 31, 2023

not a fan of those and having it at the bottom wastes useful space. Have you researched other apps?

Haven't really found examples of grids with this kind of extra button. I usually just saw lists or completely separate button for adding new items.

Not sure if it makes sense to move it up to the top then :/
It would waste less space, but then again, users tapping on that open button are most likely not looking to add a new note, so having it as a first option is probably not a good idea.

@esensar esensar force-pushed the feature/641-open-note-ui branch from 609eb97 to da61c2e Compare July 31, 2023 08:21
@esensar
Copy link
Contributor Author

esensar commented Jul 31, 2023

This is the version with this button on top. It looks nicer, but I am not sure if it makes much sense to be honest :/

notes-ui-extra-button-top

@tibbi
Copy link
Contributor

tibbi commented Jul 31, 2023

lets just add a fab there at the bottom right corner, like when creating a new folder at the destination picker in the file manager etc, people are used to that

@tibbi
Copy link
Contributor

tibbi commented Aug 1, 2023

add some bottom padding to the list so that if you scroll down as much as possible, the fab doesnt cover up any items

@tibbi
Copy link
Contributor

tibbi commented Aug 2, 2023

yeah thanks, this looks good to me. It is a pretty nice and elegant solution

@tibbi tibbi merged commit 27855d5 into SimpleMobileTools:master Aug 2, 2023
@esensar esensar deleted the feature/641-open-note-ui branch August 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants