Skip to content

Make FontType a bitflag - #8

Merged
The-Nice-One merged 1 commit into
mainfrom
polish
Aug 5, 2026
Merged

Make FontType a bitflag#8
The-Nice-One merged 1 commit into
mainfrom
polish

Conversation

@The-Nice-One

@The-Nice-One The-Nice-One commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Clarified font style formatting as a bitfield.
    • Updated the font style reference to show that a zero value means Regular, with Bold and Italic represented as flags.
    • Revised font table examples to reflect combined Bold + Italic values and reserved unused bits.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 732e8df2-3ff5-4148-a81d-ba6f0b23c08d

📥 Commits

Reviewing files that changed from the base of the PR and between 1862a6d and d11390f.

📒 Files selected for processing (3)
  • snippets/data_types/FontType.md
  • src/Data Types.md
  • src/Font Table.md

📝 Walkthrough

Walkthrough

This PR updates specification text for FontType and font_type. It replaces named style variants with a bitfield definition, defines zero as Regular, reserves bits 2–7, and updates Font Table examples to use flag-based wording and combined Bold + Italic values.

Changes

FontType bitfield specification

Layer / File(s) Summary
Define FontType as a bitfield
snippets/data_types/FontType.md, src/Data Types.md
The FontType definition now uses bit flags. Bit 0 is Bold, bit 1 is Italic, bits 2–7 are reserved, and no set bits means Regular.
Align font_type examples and descriptions
src/Font Table.md
The Font Table text now describes font_type with bitfield terminology. Regular examples say no bits are set, Bold examples identify bit 0, and the non-ASCII example changes to 0x03 for bold and italic.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch polish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@The-Nice-One
The-Nice-One merged commit d90bbfd into main Aug 5, 2026
3 of 4 checks passed
@The-Nice-One
The-Nice-One deleted the polish branch August 5, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant