This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Feature/globby#9
Merged
Merged
Conversation
TypeScript variable name validation improved.
GiedriusGrabauskas
suggested changes
Nov 3, 2017
| author?: string; | ||
| license?: string; | ||
| } | ||
| export declare type VarType = "var" | "let" | "const"; |
Contributor
There was a problem hiding this comment.
Why doesn't use an enum with string values?
GiedriusGrabauskas
suggested changes
Nov 3, 2017
| export function IsVarTypeValid(varType: string | boolean | undefined): varType is VarType | undefined { | ||
| return (varType == null || varType === "const" || varType === "let" || varType === "var"); | ||
| export function IsVarTypeValid(varType: string): varType is VarType { | ||
| return (varType === "const" || varType === "let" || varType === "var"); |
Contributor
There was a problem hiding this comment.
use enum values to check
Default `outExt` value added. `Options` renamed to `CLIOptions`.
GiedriusGrabauskas
suggested changes
Nov 6, 2017
| } | ||
|
|
||
| export function IsVarTypeValid(varType: string): varType is VarType { | ||
| return (varType === VarType.Const || varType === VarType.Let || varType === VarType.Var); |
Contributor
There was a problem hiding this comment.
Use Object.values
Object.values changed to generic.
GiedriusGrabauskas
suggested changes
Nov 6, 2017
|
|
||
| export function IsVarTypeValid(varType: string): varType is VarType { | ||
| return (varType === VarType.Const || varType === VarType.Let || varType === VarType.Var); | ||
| const values = Object.values(VarType) as string[]; |
| "declarationDir": "@types" | ||
| "declarationDir": "@types", | ||
| "lib": [ | ||
| "es2017" |
Contributor
There was a problem hiding this comment.
Use es2017.object
| export function IsVarTypeValid(varType: string): varType is VarType { | ||
| const values = Object.values(VarType) as string[]; | ||
| const values = Object.values<string>(VarType); | ||
| return (values.indexOf(varType) >= 0); |
GiedriusGrabauskas
approved these changes
Nov 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.