Skip to content

Feature: Remake #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 5, 2017
Merged

Feature: Remake #3

merged 23 commits into from
Dec 5, 2017

Conversation

@MartynasZilinskas
Copy link
Collaborator

@MartynasZilinskas MartynasZilinskas commented Dec 5, 2017 •
edited
Loading

  • Created file-manager: that handles reference links and how files should look
  • Added reference links
  • Added ApiVariable plugin
  • Created function to convert TypeDto to string and collects type references
  • Changed from dummy tests to real ones

MartynasZilinskas
MartynasZilinskas commented Dec 5, 2017
View reviewed changes
packages/ts-docs-gen/src/extractor-helpers.ts Outdated
break;
}
const referenceTuples = GetReferenceTuples(extractedData, entryFile, [[apiItem.Name, apiItem.ApiItems]]);
list.concat(referenceTuples);
Copy link
Collaborator Author

@MartynasZilinskas MartynasZilinskas Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concat return is not used.

@MartynasZilinskas MartynasZilinskas merged commit c30581a into dev Dec 5, 2017
@MartynasZilinskas MartynasZilinskas deleted the feature/remake branch December 5, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeividasBakanas DeividasBakanas DeividasBakanas approved these changes

+1 more reviewer

@DonatasBrazionis DonatasBrazionis DonatasBrazionis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MartynasZilinskas MartynasZilinskas

@DeividasBakanas DeividasBakanas

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MartynasZilinskas @DonatasBrazionis @DeividasBakanas