Feature: Tests generator tool #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
December 6, 2017 16:13
…r-tool # Conflicts: # common/config/rush/npm-shrinkwrap.json # packages/ts-docs-gen/package.json # packages/ts-docs-gen/tests/scripts/tests-generator.ts
DonatasBrazionis
requested review from
DeividasBakanas and
MartynasZilinskas
MartynasZilinskas
changed the title
MartynasZilinskas
approved these changes
Dec 13, 2017
DeividasBakanas
requested changes
Dec 18, 2017
| .version(`Current version: ${GetVersion()}`) | ||
| .alias("v", "version") | ||
| // CLI options | ||
| .option("path", { |
There was a problem hiding this comment.
Consider renaming to "project".
| } | ||
|
|
||
| (async (argumentsObject: CLIArgumentsObject) => { | ||
| let cwd: string; |
There was a problem hiding this comment.
Can be replaced with:
const cwd = argumentObject.path || process.cwd();| return; | ||
| } | ||
|
|
||
| const casesDirPaths = await fastGlob([ |
There was a problem hiding this comment.
Reconsider formatting:
const casesDirPaths = await fastGlob(
[
`${testsCasesPath}/*`
],
{
onlyDirs: true,
ignore: [`**/${GENERATED_TESTS_DIR_NAME}/**`]
}
);or
const casesDirPaths = await fastGlob(
[`${testsCasesPath}/*`],
{
onlyDirs: true,
ignore: [`**/${GENERATED_TESTS_DIR_NAME}/**`]
}
);| return pathname.split(path.sep).join("/"); | ||
| } | ||
|
|
||
| export function Tab(size: number = 1): string { |
There was a problem hiding this comment.
Is this helper still useful?
DeividasBakanas
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.