Feature: Upgrade ts-extractor #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 21, 2017 17:53
MartynasZilinskas
force-pushed
the
feature/upgrade
branch
from
029b793 to
70c78d2
Compare
DeividasBakanas
requested changes
Dec 21, 2017
| const referenceTuples = GetApiItemReferences(extractedData, [[apiItem.Name, apiItem.ApiItems]]); | ||
| list = list.concat(referenceTuples); | ||
|
|
||
| const referencesList = GetApiItemReferences(extractedData, [{ Alias: apiItem.Name, Ids: apiItem.ApiItems }]); |
There was a problem hiding this comment.
Move to separate const just like in line 144.
| itemsReference: Contracts.ApiItemReferenceTuple | ||
| itemsReference: Contracts.ApiItemReference[] | ||
| ): ApiItemReference[] { | ||
| let list: ApiItemReference[] = []; |
There was a problem hiding this comment.
Consider changing variable list name to overallReferences.
| return apiItems; | ||
| } | ||
|
|
||
| export function LogWithApiItemPosition(logLevel: LogLevel, apiItem: Contracts.ApiItemDto, message: string): void { |
There was a problem hiding this comment.
Maybe default value for logLevel would be handy?
export function LogWithApiItemPosition(apiItem: Contracts.ApiItemDto, message: string, logLevel: LogLevel = LogLevel.Warning): void(default value can be other than LogLevel.Warning)
There was a problem hiding this comment.
I am not really sure if it's right decision. Because default Log function for logging is:
Log: (level: LogLevel, ...messages: any[]) => number;
DeividasBakanas
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.