WIP DLC skills - #2
Conversation
| hsy_entrepreneur_skill = "Entrepreneur Skill" | ||
| hr_horse_riding_skill = "Horse Riding Skill" | ||
| hr_nectar_making_skill = "Nectar Making Skill" | ||
| cc_gemology_skill = "Gemology Skill" |
There was a problem hiding this comment.
I can't remember for the life of me what cc means lol (the rest of them I think are fairly easy to understand, nk is nifty knitting, sy is snowy escape (maybe sy could be sc instead? not sure) pa is... oh no I don't remember either... cgl is cottage living, hsy is high school years, hr is horse ranch, lv is love struck, and is life and death, bnh is businesses and hobbies, ebn is enchanted by nature)
There was a problem hiding this comment.
Cc is Crystal Creations Stuff. It's an entirely forgettable pack that for some reason added a skill.
Pa is Paranormal.
There was a problem hiding this comment.
ahhhh right yeah that makes a lot of sense LOL
There was a problem hiding this comment.
ahhhh paranormal stuff right... yep very forgettable
| for i in range(item["count"]): | ||
| sims4_item = self.create_item(item["name"]) | ||
| pool.append(sims4_item) | ||
| for item_data in item_table.values(): |
There was a problem hiding this comment.
the refactor here looks great, and I'm hoping it just works fine with my multi-career PR branch I had been working on
| 'expansion': "base"}, | ||
| skill_locations_table: dict[int, Sims4LocationDict] = {} | ||
|
|
||
| def add_skill_location(skill_name: str, expansion: str, max_level: int) -> int: |
There was a problem hiding this comment.
this, and the items are MUCH better methods of generating the location/item table
# Conflicts: # worlds/sims4/__init__.py
|
Merged. Thank you :D |
Resync the repository with Main AP
3 participants
This should be everything needed on the apworld side to support DLC skills.
I have not touched the visibility yet, as it definitely shouldn't be turned on without corresponding mod changes.