fix(migrate): relax integration test — version from filename prefix not file count - #485
Merged
Conversation
The TestRun_IntegrationApplyAndRollback assertion required count(*.up.sql) == max_applied_version. That breaks when parallel branches each pick a non-contiguous migration slot (every PR's CI fails until you renumber every other PR's migration). Use the lexically-greatest filename's numeric prefix instead — the migration runner uses the prefix as the version anyway, so the assertion is still meaningful but no longer over-constrained. Signed-off-by: Tayeb Mokni <tayeb.mokni@gmail.com>
tayebmokni
enabled auto-merge (squash)
May 26, 2026 18:26
Pushes the testing.Short() skip up into the three container helpers themselves rather than scattering it across 20+ call sites. Every integration test that calls containers.Postgres(), .Redis(), or .MinIO() now skips automatically under -short. The nightly-full-tests workflow runs without -short so these paths are still exercised against tip-of-main. Signed-off-by: Tayeb Mokni <tayeb.mokni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was blocking every PR with a migration that skipped a slot. See body for why.
🤖 Generated with Claude Code