Skip to content

test(repair): prove fair rotation prevents starvation#3031

Merged
Sinity merged 1 commit into
masterfrom
feature/test/raw-authority-fairness-mutation
Jul 17, 2026
Merged

test(repair): prove fair rotation prevents starvation#3031
Sinity merged 1 commit into
masterfrom
feature/test/raw-authority-fairness-mutation

Conversation

@Sinity

@Sinity Sinity commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

Add a real-route adversarial mutation proving raw-authority attempt-age rotation prevents bounded-slot starvation.

Problem

Fair scheduling was covered positively, but the scale proof lacked evidence that removing its durable attempt ordering recreates the observed non-progress failure mode.

Solution

Inject a retryable oldest component across a one-slot scheduler. The production order advances to independent work; the acquisition-only mutation selects the same retrying component again.

Ref polylogue-hjpx.2.

Verification

  • Focused fairness mutation test passed.
  • Mypy for the test passed.
  • Pre-push quick verification passed.

The adversarial mutation removes durable attempt-age ordering. A retryable oldest component then monopolizes the bounded slot, while the production scheduler selects independent newer work.\n\nRef polylogue-hjpx.2.
@Sinity
Sinity merged commit f6b0442 into master Jul 17, 2026
1 check passed
@Sinity
Sinity deleted the feature/test/raw-authority-fairness-mutation branch July 17, 2026 13:25
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Sinity, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f2d5fdf1-c5b3-4ae7-b65a-b322cc5b2211

📥 Commits

Reviewing files that changed from the base of the PR and between 5b40d57 and 7150883.

📒 Files selected for processing (1)
  • tests/unit/storage/test_repair.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/test/raw-authority-fairness-mutation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sinity added a commit that referenced this pull request Jul 18, 2026
Problem: hjpx.2 needs a proof-report artifact recording verdict per
law (envelope/health/fairness/fixed-point/mutations) regardless of
whether the July-15-scale execution itself completes this session.

Solution: report distinguishes proven-at-small-scale (envelope,
fairness, conservation, interruption/resume, pressure-gate mutations
-- all verified passing this session, several inherited from prior
PRs like #3080/#3029/#3031) from genuinely unproven (daemon-health
responsiveness -- confirmed no harness runs an actual daemon process
to probe; filed polylogue-agvo) and not-yet-executed-at-cardinality
(the July-15-shaped run itself -- three self-aborts under sustained,
genuine host I/O contention across 4+ concurrent warroom lanes,
receipts recorded). Explicitly states hjpx.2 is not closable this
session rather than forcing a close on unmet AC.

Verification: cited tests re-run and confirmed passing (see report
for exact node list); no archive mutation.

Ref polylogue-hjpx.2

Co-Authored-By: Claude <noreply@anthropic.com>
Sinity added a commit that referenced this pull request Jul 18, 2026
Problem: hjpx.2 needs a proof-report artifact recording verdict per
law (envelope/health/fairness/fixed-point/mutations) regardless of
whether the July-15-scale execution itself completes this session.

Solution: report distinguishes proven-at-small-scale (envelope,
fairness, conservation, interruption/resume, pressure-gate mutations
-- all verified passing this session, several inherited from prior
PRs like #3080/#3029/#3031) from genuinely unproven (daemon-health
responsiveness -- confirmed no harness runs an actual daemon process
to probe; filed polylogue-agvo) and not-yet-executed-at-cardinality
(the July-15-shaped run itself -- three self-aborts under sustained,
genuine host I/O contention across 4+ concurrent warroom lanes,
receipts recorded). Explicitly states hjpx.2 is not closable this
session rather than forcing a close on unmet AC.

Verification: cited tests re-run and confirmed passing (see report
for exact node list); no archive mutation.

Ref polylogue-hjpx.2

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant