fix: Private demo packet sat un-ignored in the public tree; decide the… - #4617
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cbb9c36c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !.agent/demos/** | ||
| # Demo shelf permits only the synthetic attachment census. Other demo | ||
| # directories are generated or private evidence and must stay local. | ||
| .agent/demos/* |
There was a problem hiding this comment.
At the reviewed head, adding a new neutral curated demo such as .agent/demos/new-demo/README.md is silently skipped by git add, even though .agent/CONVENTIONS.md lines 35 and 85–88 and .agent/README.md lines 10–13 still describe demos/ as a tracked curated shelf. If the intended policy is now census-only, update those repository instructions so contributors do not follow a documented workflow that cannot publish its output.
Useful? React with 👍 / 👎.
1 participant
Summary
Keep the attachment-acquisition census as the only tracked
.agent/demosartifact and ignore all other demo directories.Problem
The demo-packet v2 validator, registry, and packet shelves were removed by
c17e38539(#3950). The surviving census is synthetic and explicitly read-only, while the existing.gitignoreexception!.agent/demos/**allowed future private packet material to be staged accidentally.Solution
Add a deny rule for
.agent/demos/*with an explicit exception forattachment-acquisition-census. This implements the census-only disposition and prevents untracked private packet paths from entering the public tree.Verification
git check-ignore -v -- .agent/demos/private-packet/packet.json .agent/demos/d1-receipts/evidence.ndjson .agent/demos/attachment-acquisition-census/census.json .agent/demos/attachment-acquisition-census/new.txtpassed: private paths matched.agent/demos/*, the tracked census file was not ignored, and new census files matched the explicit exception.uv run devtools test tests/unit/democompleted with34 failed, 17 passed, 1 warning in 463.39s. The failures occur during demo archive seeding because Hermes fixture tool results lack structured outcome evidence; this is inherited and unrelated to.gitignore.Residual risk
The focused demo suite remains red until the inherited Hermes fixture/outcome mismatch is repaired. Existing tracked private files would require a separate deletion change; none remain in this worktree.