test(maintenance): build the empty-uncovered shape the planner-stats test claims - #4699
Merged
Merged
Conversation
…test claims Per-table ANALYZE records zero-row sqlite_stat1 entries for an empty table, so the fixture never had the shape the test asserted and it failed on master. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DNGJ3awfNrsLaMdHgQZvid
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The planner-stats coverage test asserted that an empty
action_pairstable has nosqlite_stat1rows and failed on master.Problem
Per-table
ANALYZE(used by the archive builders) records zero-rowsqlite_stat1entries for an empty table, so the fixture never had the shape the test claimed. Confirmed on master f80542b:devtools test tests/unit/maintenance/test_archive_verification.py→ 1 failed.Solution
The test removes the fixture's stat rows to build the uncovered-but-empty shape it exercises; the gate's comment names the bare-
ANALYZEcase it describes. Gate logic unchanged.Verification
Direct call of the test body against the fixture passes; focused
devtools teston the file queued behind the corpus run.🤖 Generated with Claude Code
https://claude.ai/code/session_01DNGJ3awfNrsLaMdHgQZvid