Refactor TextMeasurer advance/bounds measurement#506
Merged
JimBobSquarePants merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=====================================
- Coverage 83% 83% -1%
=====================================
Files 274 274
Lines 19171 19167 -4
Branches 2717 2714 -3
=====================================
- Hits 16071 16048 -23
- Misses 2424 2441 +17
- Partials 676 678 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This pull request introduces significant improvements to the text measurement API in
TextMeasurer, clarifying the distinction between logical advance, rendered bounds, and their union, and adding new methods for more granular measurement. It also updates the implementation to use a more robust layout model and adds new per-character measurement capabilities. Several test image references have been updated to reflect these changes.API and documentation improvements:
TextMeasurer, distinguishing between logical advance, rendered glyph bounds, normalized size, and full renderable bounds. New remarks and references help users select the correct measurement method for their needs.MeasureRenderableBoundsandTryMeasureCharacterRenderableBounds, which return the union of logical advance and rendered glyph bounds, both for whole text and per-character entry.Implementation changes:
TextLayout.TextBoxmodel, providing more accurate line and layout metrics, and simplified the logic for both horizontal and vertical layouts.TryGetCharacterRenderableBoundsto compute per-character union bounds for advanced measurement scenarios.Test updates:
tests/Images/ReferenceOutputto reflect the new measurement and rendering logic, resulting in changed output images and sizes. [1] [2] [3] [4] [5] [6] [7] [8]