Skip to content

Rename FeatureTags to match standard#521

Merged
JimBobSquarePants merged 1 commit intomainfrom
js/featuretags
Apr 5, 2026
Merged

Rename FeatureTags to match standard#521
JimBobSquarePants merged 1 commit intomainfrom
js/featuretags

Conversation

@JimBobSquarePants
Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This pull request refactors the handling of OpenType feature tags throughout the codebase. The main change is renaming the FeatureTags enum to KnownFeatureTags and updating all references to use the new name. This improves clarity and consistency, as well as future-proofs the code for distinguishing between known and custom feature tags. The changes affect both the main library and related tests.

@JimBobSquarePants JimBobSquarePants merged commit 7396060 into main Apr 5, 2026
24 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/featuretags branch April 5, 2026 11:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82%. Comparing base (6011281) to head (e50629b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...Tables/AdvancedTypographic/Shapers/HangulShaper.cs 75% 1 Missing ⚠️
...Tables/AdvancedTypographic/Shapers/HebrewShaper.cs 0% 1 Missing ⚠️
...ables/AdvancedTypographic/Shapers/MyanmarShaper.cs 0% 1 Missing ⚠️
src/SixLabors.Fonts/TextLayout.cs 50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #521   +/-   ##
=====================================
  Coverage     82%     82%           
=====================================
  Files        305     305           
  Lines      21534   21534           
  Branches    3165    3165           
=====================================
  Hits       17818   17818           
  Misses      2901    2901           
  Partials     815     815           
Flag Coverage Δ
unittests 82% <84%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant