Fix rich text cloning and palette cache key - #413
Merged
Conversation
Adds missing RichTextRun fields to the RichTextOptions copy constructor, including feature tags, shaping metadata, color font settings, and font palette, so cloned options preserve run behavior correctly. It also includes FontPalette in glyph cache keys to prevent cache collisions between palette variants, and updates SixLabors.Fonts/ImageSharp package versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=====================================
Coverage 79% 79%
=====================================
Files 232 232
Lines 27340 27356 +16
Branches 3112 3113 +1
=====================================
+ Hits 21859 21874 +15
Misses 4589 4589
- Partials 892 893 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds missing
RichTextRunfields to theRichTextOptionscopy constructor, including feature tags, shaping metadata, color font settings, and font palette, so cloned options preserve run behavior correctly. It also includesFontPalettein glyph cache keys to prevent cache collisions between palette variants, and updates SixLabors.Fonts/ImageSharp package versions.