fix: address all Copilot review issues (PR #1, #2, #3)#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all Copilot review issues found across PR #1, #2, and #3.
PR #1 fixes (6 issues)
onFiretwice; fixed routing logic so teammate tasks go throughonFireTaskonly, lead tasks go throughonFireonlyrunForked()loggedparentHistory.size()before null check; moved size computation after null guardresponseQueueand terminal rendering; addedsynchronizedonresolve();provideResponse()now clears queue beforeput()to prevent silent dropsagentIdwas read incall()but not declared ininputSchema(); added to propertiesPR #2 fixes (1 issue)
REPL_ONLY_TOOLSwhen REPL mode is enabledPR #3 fixes (5 issues)
java.util.function.ConsumerimportPermissionResult.Askwas silently allowed, bypassing user confirmation; now returns a denial messagecontextTemplatecould cause NPEs in tools; constructor now normalizes toToolUseContext.defaultContext()e.getMessage()only; now passes exception object as last param for full stacktraceTest Results