refactor(message-parser): optimize code point matchers#20
Merged
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ramsey
force-pushed
the
refactor/optimize-code-point-matchers
branch
from
86a4db6 to
a927da0
Compare
maccath
approved these changes
Dec 13, 2021
|
Code Climate has analyzed commit 762d488 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I had a long-ish thread on Twitter, where I discussed the code for these matchers with some friends, and I ran some benchmarks to evaluate various versions of the code. I ended up optimizing the code by collapsing the ranges in these logical expressions so that they are more concise, and this ended up significantly improving these functions.
I also added docblocks and unit tests.
Product requirements and context
The matchers were slow, and I wondered whether I could optimize them.
How has this been tested?
PR Checklist