feat: provide --flatten option for hoisting selectors#22
Merged
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jmauerhan
approved these changes
Dec 13, 2021
maccath
approved these changes
Dec 13, 2021
| * The goal is to provide as many full sentences as possible since | ||
| * fragmented sentences are not translator-friendly. | ||
| */ | ||
| public function hoistSelectors(ElementCollection $ast): ElementCollection |
There was a problem hiding this comment.
Function hoistSelectors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 1b36e96 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 96.3% (0.2% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a
--flattenextraction option to tell the extractor to hoist selectors and flatten sentences as much as possible. For example,becomes
The goal is to provide as many full sentences as possible, since fragmented sentences are not translator-friendly.
Product requirements and context
How has this been tested?
PR Checklist