feat: improve tag support for parity with formatjs#24
Merged
Conversation
|
Code Climate has analyzed commit edf14dc and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.1% change). View more on Code Climate. |
maccath
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turns out that FormatJS doesn't parse real HTML/XML tags in messages. Instead, they use custom tags that can be associated with a callback to replace the tag with a computed value.
For example:
When rendered, this will produce:
See: https://formatjs.io/docs/intl#defaultrichtextelements
In the
Configobject, we're also able to pass in a "global" array of callbacks as thedefaultRichTextElementsparameter. Any named callbacks configured this way will apply to all formatted messages.For example:
This will produce:
Product requirements and context
To support pseudo-locale generation, we have implemented a parser that is identical to that of FormatJS. This means our parser can't properly handle attributes and all the inside guts of an HTML tag. As a result, we can't pass
<a>tags with HREFs. So, we need to implement the same tag functionality as FormatJS.I think this is the last requirement before I can finally finish pseudo locales.
How has this been tested?
PR Checklist