Allow multiple HandlerOrder attributes on a single handler class - #4
Merged
Merged
Conversation
1、Set AllowMultiple on HandlerOrder attributes and collect every attribute in the generator 2、Add generator Verify and integration tests for multi-context handlers 3、Document in ChainOfResponsibility.md and mark ROADMAP item complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllowMultipleonHandlerOrderAttribute/HandlerOrderAttribute<TContext>.HandlerOrderGeneratorcollects every attribute instance (aligned withRegisterStrategyGenerator) and still groups pipelines by context type.Closes #3
Test plan
dotnet test DesignPatterns.slnx -c Release(173 tests)Note
Low Risk
Additive generator and attribute usage change with existing DP005 validation and new tests; no auth or data-path changes.
Overview
Enables multiple
[HandlerOrder]/[HandlerOrder<TContext>]attributes on one handler class, so a single type can join separate generated pipelines for different context types (e.g. shared logging forRequestContextandAuditContext).HandlerOrderGeneratornow emits one registration per attribute instance (not only the first) and flattens collected outputs before building per-context pipelines. Duplicate order for the same context still raises DP005, including when two attributes on the same class target the same context.Docs and roadmap note the feature; generator Verify snapshots and an integration test cover multi-context pipelines and same-class duplicate order.
.gitignoreadds.nuke/temp/.Reviewed by Cursor Bugbot for commit b2e52fb. Configure here.