Skip to content

chore(rust-native): crates.io release prep — published as rustwright 0.1.1 - #106

Merged
suchintan merged 2 commits into
mainfrom
repo-sync/rustwright-cloud-103
Jul 20, 2026
Merged

chore(rust-native): crates.io release prep — published as rustwright 0.1.1#106
suchintan merged 2 commits into
mainfrom
repo-sync/rustwright-cloud-103

Conversation

@suchintan

Copy link
Copy Markdown
Member

@suchintan suchintan added the sync Automated cross-repository sync label Jul 20, 2026
@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Summary

Small, low-risk release-prep PR (crates.io metadata + version bump for the rustwright native crate, plus a new rust-native/README.md). No engine/CDP/FFI code touched. One real bug: the README's usage example won't compile against the actual API.

🔴 Critical Issues (1)
  • rust-native/README.md example doesn't compile. Page::goto and Page::title take a concrete options struct (GotoOptions, ActionOptions), not Option<T> — see rust-native/src/lib.rs:231 and :252. The README calls page.goto("https://example.com", None) and page.title(None), which will fail to type-check. Compare with the working rust-native/examples/quickstart.rs, which correctly uses GotoOptions::default() and Default::default(). Since readme = "README.md" is set in Cargo.toml, this is the example that shows up on crates.io and will be the first thing a new user copy-pastes and hits a compile error on. Fix: page.goto("https://example.com", Default::default())?; and page.title(Default::default())?; (or GotoOptions::default() / ActionOptions::default() explicitly). Also note this isn't caught by CI — nothing doctests the README (bindings.yml doesn't build/test it), so this would have shipped silently.
🟡 Suggestions (1)
  • Consider wiring the README code block into cargo test --doc (e.g. via #[doc = include_str!("../README.md")] on the crate root, or a doctest crate) so future README edits get compile-checked automatically rather than relying on manual review.
📝 Minor / Style (1)
  • Version bump (0.1.0-alpha.40.1.1) and the pinned rustwright-core dependency version (version = "0.1.1") are consistent with Cargo.toml's core crate version — good. No parity/behavior changes here, so no additional pytest coverage needed for this PR.

@suchintan
suchintan merged commit bc367d1 into main Jul 20, 2026
14 of 15 checks passed
@suchintan
suchintan deleted the repo-sync/rustwright-cloud-103 branch July 20, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync Automated cross-repository sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant