missing TAG, and vtkAddonConfig.cmake is not installed

[ferdymercury]

The CMake script is not installed when calling make install, meaning it's not really useable by packagers.
Could it be exported into the install tree?

@AlexyPellegrini

I saw that you worked on this recently, maybe I am missing a special flag? Or it only works for some CMAKE_BUILD_TYPE s ?

this is what I see locally:

- Installing: /tmp/vtkAddon/install/lib/vtkAddon/libvtkAddon.so
-- Set non-toolchain portion of runtime path of "/tmp/vtkAddon/install/lib/vtkAddon/libvtkAddon.so" to ""
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkAddonFunctionAddExecutable.cmake
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkAddonFunctionAddExecutable.cmake
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkMacroKitPythonWrap.cmake
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkWrapHierarchy.cmake
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkWrapperInit.data.in
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/vtkWrapPython.cmake
-- Up-to-date: /tmp/vtkAddon/install/vtkAddon/lib/cmake/vtkAddon/WindowsApplicationUseUtf8.manifest

After fixing this it would be great to have a "tag" or "release".

[AlexyPellegrini]

Hi @ferdymercury,

It is indeed a CMake variable to set: vtkAddon_INSTALL_NO_DEVELOPMENT=OFF Default value is ON because it already was set to this default value when I worked on it.

[ferdymercury]

Thanks a lot for the swift reply!
Could this be documented somewhere?
Or at least changing this variable to be visible when one calls "ccmake"

Side note: btw the path looks a bit convoluted:
install/vtkAddon/lib/cmake/vtkAddon/

[ferdymercury]

@lassoan could a TAG be published? Last one is from 2022
Thanks in advance!

[AlexyPellegrini]

There is indeed a lack of build documentation, but all these variables should be visible using CMake-gui or ccmake.

For the install destination, this is the default value, which is one of the CMake modules directory suitable for find_package but it can be changed using vtkAddon_INSTALL_CMAKE_DIR.

[ferdymercury]

ccmake.

For some reason, that variable vtkAddon_INSTALL_NO_DEVELOPMENT does not appear on my ccmake:

pkgcfg_lib_PKG_FONTCONFIG_font * /usr/lib/x86_64-linux-gnu/libfontconfig.so
 pkgcfg_lib_PKG_FONTCONFIG_free * /usr/lib/x86_64-linux-gnu/libfreetype.so
 vtkAddon_LAUNCH_COMMAND        * 
 vtkAddon_USE_UTF8              * OFF
 CMAKE_ADDR2LINE                  /usr/bin/addr2line
 CMAKE_AR                         /usr/bin/ar

Maybe because it's a variable rather an an "option" ?

[AlexyPellegrini]

I just checked and indeed they are not cache variables at all, I don't know why, they simply never has been, looking at the history. I think they could be tho.

[ferdymercury]

Indeed if I change to:

if(NOT DEFINED ${PROJECT_NAME}_INSTALL_NO_DEVELOPMENT)
  option(${PROJECT_NAME}_INSTALL_NO_DEVELOPMENT "aaa" ON)
else()
  option(${PROJECT_NAME}_INSTALL_NO_DEVELOPMENT "aaa" OFF)
endif()

then it appears on ccmake.

So I'd propose either to document better those variables in the README and leave the code as-is, or to leave the README untouched but change from variables to OPTIONS.