Skip to content

Do auth while loading#356

Merged
NunoDasNeves merged 3 commits intodevfrom
do-auth-while-loading
Feb 11, 2019
Merged

Do auth while loading#356
NunoDasNeves merged 3 commits intodevfrom
do-auth-while-loading

Conversation

@NunoDasNeves
Copy link
Collaborator

@NunoDasNeves NunoDasNeves commented Feb 11, 2019

I noticed app load still looks very ugly due to checkAuth blocking the router and therefore stopping the main routerview showing anything, and the buttons in the nav changing while the page is loading.
So I added startLoad and endLoad to checkAuth and now it's all hidden! yay?

@NunoDasNeves NunoDasNeves self-assigned this Feb 11, 2019
@coveralls
Copy link

coveralls commented Feb 11, 2019

Pull Request Test Coverage Report for Build 1683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.228%

Totals Coverage Status
Change from base Build 1681: 0.0%
Covered Lines: 680
Relevant Lines: 740

💛 - Coveralls

Copy link
Collaborator

@DarkPurple141 DarkPurple141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, now wondering whether having the render-blocking auth check is needed now as it'll be resolved behind the loader any way?

@NunoDasNeves
Copy link
Collaborator Author

NunoDasNeves commented Feb 11, 2019

@DarkPurple141 #shell just (visually) covers #app while loading right?
In this case we do still need the authCV, cos it's purpose is actually to block further requests from going out until checkAuth resolves (specifically, GET requests that return stuff dependent on the auth token)

@NunoDasNeves NunoDasNeves merged commit 88c2deb into dev Feb 11, 2019
@NunoDasNeves NunoDasNeves deleted the do-auth-while-loading branch February 11, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants